From 916d84bdca52d04b8a808cc3e519ddc1ee3c2ffe Mon Sep 17 00:00:00 2001
From: Dehravor <dehravor@gmail.com>
Date: Sun, 9 Feb 2014 10:51:11 +0100
Subject: Core/Group: Add sanity checks to CMSG_LOOT_METHOD's handler

If lootMethod or lootThreshold is invalid, portrait menus become unusable to the entire raid.
---
 src/server/game/Handlers/GroupHandler.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

(limited to 'src/server')

diff --git a/src/server/game/Handlers/GroupHandler.cpp b/src/server/game/Handlers/GroupHandler.cpp
index 6404d3c8e41..3b0ee4e24be 100644
--- a/src/server/game/Handlers/GroupHandler.cpp
+++ b/src/server/game/Handlers/GroupHandler.cpp
@@ -425,6 +425,12 @@ void WorldSession::HandleLootMethodOpcode(WorldPacket& recvData)
     /** error handling **/
     if (!group->IsLeader(GetPlayer()->GetGUID()))
         return;
+
+    if (lootMethod > NEED_BEFORE_GREED)
+        return;
+
+    if (lootThreshold < ITEM_QUALITY_UNCOMMON || lootThreshold > ITEM_QUALITY_ARTIFACT)
+        return;
     /********************/
 
     // everything's fine, do it
-- 
cgit v1.2.3