From bab5fd87a34d92737e92d0850be05890a5ce8e24 Mon Sep 17 00:00:00 2001 From: Peter Keresztes Schmidt Date: Tue, 23 Jun 2020 08:54:12 +0200 Subject: Core/Misc: Replace Trinity::make_unique with std (#24869) --- src/server/bnetserver/REST/LoginRESTService.cpp | 6 +++--- src/server/database/Database/DatabaseWorkerPool.cpp | 6 +++--- src/server/database/Database/MySQLConnection.cpp | 4 ++-- src/server/database/Updater/UpdateFetcher.cpp | 2 +- src/server/game/Entities/AreaTrigger/AreaTrigger.cpp | 2 +- src/server/game/Entities/GameObject/GameObject.cpp | 2 +- src/server/game/Entities/Player/CollectionMgr.cpp | 2 +- src/server/game/Entities/Player/Player.cpp | 8 ++++---- src/server/game/Entities/Unit/Unit.cpp | 4 ++-- src/server/game/Globals/ObjectMgr.h | 2 +- src/server/game/Groups/Group.cpp | 2 +- src/server/game/Maps/Map.cpp | 2 +- src/server/game/Maps/Map.h | 2 +- src/server/game/Scripting/ScriptMgr.cpp | 2 +- src/server/game/Scripting/ScriptReloadMgr.cpp | 2 +- src/server/game/Server/Packets/AuthenticationPackets.cpp | 2 +- src/server/game/Server/Packets/MiscPackets.cpp | 2 +- src/server/game/Server/WorldSession.cpp | 4 ++-- src/server/game/Spells/Spell.cpp | 2 +- src/server/shared/Realm/RealmList.cpp | 12 ++++++------ src/server/worldserver/Main.cpp | 6 +++--- 21 files changed, 38 insertions(+), 38 deletions(-) (limited to 'src/server') diff --git a/src/server/bnetserver/REST/LoginRESTService.cpp b/src/server/bnetserver/REST/LoginRESTService.cpp index 9afaeb5df8c..c8fb91b163b 100644 --- a/src/server/bnetserver/REST/LoginRESTService.cpp +++ b/src/server/bnetserver/REST/LoginRESTService.cpp @@ -253,7 +253,7 @@ int32 LoginRESTService::HandleGetGameAccounts(std::shared_ptr requ if (!request->GetClient()->userid) return 401; - request->SetCallback(Trinity::make_unique(LoginDatabase.AsyncQuery([&] { + request->SetCallback(std::make_unique(LoginDatabase.AsyncQuery([&] { LoginDatabasePreparedStatement* stmt = LoginDatabase.GetPreparedStatement(LOGIN_SEL_BNET_GAME_ACCOUNT_LIST); stmt->setString(0, request->GetClient()->userid); return stmt; @@ -345,7 +345,7 @@ int32 LoginRESTService::HandlePostLogin(std::shared_ptr request) std::string sentPasswordHash = CalculateShaPassHash(login, password); - request->SetCallback(Trinity::make_unique(LoginDatabase.AsyncQuery(stmt) + request->SetCallback(std::make_unique(LoginDatabase.AsyncQuery(stmt) .WithChainingPreparedCallback([request, login, sentPasswordHash, this](QueryCallback& callback, PreparedQueryResult result) { if (result) @@ -444,7 +444,7 @@ int32 LoginRESTService::HandlePostRefreshLoginTicket(std::shared_ptrGetClient()->userid) return 401; - request->SetCallback(Trinity::make_unique(LoginDatabase.AsyncQuery([&] { + request->SetCallback(std::make_unique(LoginDatabase.AsyncQuery([&] { LoginDatabasePreparedStatement* stmt = LoginDatabase.GetPreparedStatement(LOGIN_SEL_BNET_EXISTING_AUTHENTICATION); stmt->setString(0, request->GetClient()->userid); return stmt; diff --git a/src/server/database/Database/DatabaseWorkerPool.cpp b/src/server/database/Database/DatabaseWorkerPool.cpp index 0cb755ce073..39330288a8d 100644 --- a/src/server/database/Database/DatabaseWorkerPool.cpp +++ b/src/server/database/Database/DatabaseWorkerPool.cpp @@ -69,7 +69,7 @@ template void DatabaseWorkerPool::SetConnectionInfo(std::string const& infoString, uint8 const asyncThreads, uint8 const synchThreads) { - _connectionInfo = Trinity::make_unique(infoString); + _connectionInfo = std::make_unique(infoString); _async_threads = asyncThreads; _synch_threads = synchThreads; @@ -365,9 +365,9 @@ uint32 DatabaseWorkerPool::OpenConnections(InternalIndex type, uint8 numConne switch (type) { case IDX_ASYNC: - return Trinity::make_unique(_queue.get(), *_connectionInfo); + return std::make_unique(_queue.get(), *_connectionInfo); case IDX_SYNCH: - return Trinity::make_unique(*_connectionInfo); + return std::make_unique(*_connectionInfo); default: ABORT(); } diff --git a/src/server/database/Database/MySQLConnection.cpp b/src/server/database/Database/MySQLConnection.cpp index bde2004afdf..f141663b824 100644 --- a/src/server/database/Database/MySQLConnection.cpp +++ b/src/server/database/Database/MySQLConnection.cpp @@ -62,7 +62,7 @@ m_Mysql(NULL), m_connectionInfo(connInfo), m_connectionFlags(CONNECTION_ASYNC) { - m_worker = Trinity::make_unique(m_queue, this); + m_worker = std::make_unique(m_queue, this); } MySQLConnection::~MySQLConnection() @@ -486,7 +486,7 @@ void MySQLConnection::PrepareStatement(uint32 index, std::string const& sql, Con m_prepareError = true; } else - m_stmts[index] = Trinity::make_unique(reinterpret_cast(stmt), sql); + m_stmts[index] = std::make_unique(reinterpret_cast(stmt), sql); } } diff --git a/src/server/database/Updater/UpdateFetcher.cpp b/src/server/database/Updater/UpdateFetcher.cpp index 3241d7feea6..b34cb9ff39c 100644 --- a/src/server/database/Updater/UpdateFetcher.cpp +++ b/src/server/database/Updater/UpdateFetcher.cpp @@ -42,7 +42,7 @@ UpdateFetcher::UpdateFetcher(Path const& sourceDirectory, std::function const& apply, std::function const& applyFile, std::function const& retrieve) : - _sourceDirectory(Trinity::make_unique(sourceDirectory)), _apply(apply), _applyFile(applyFile), + _sourceDirectory(std::make_unique(sourceDirectory)), _apply(apply), _applyFile(applyFile), _retrieve(retrieve) { } diff --git a/src/server/game/Entities/AreaTrigger/AreaTrigger.cpp b/src/server/game/Entities/AreaTrigger/AreaTrigger.cpp index b1c386d2e51..a0c122f88b8 100644 --- a/src/server/game/Entities/AreaTrigger/AreaTrigger.cpp +++ b/src/server/game/Entities/AreaTrigger/AreaTrigger.cpp @@ -639,7 +639,7 @@ void AreaTrigger::InitSplines(std::vector splinePoints, uint32 tim _movementTime = 0; - _spline = Trinity::make_unique<::Movement::Spline>(); + _spline = std::make_unique<::Movement::Spline>(); _spline->init_spline(&splinePoints[0], splinePoints.size(), ::Movement::SplineBase::ModeLinear); _spline->initLengths(); diff --git a/src/server/game/Entities/GameObject/GameObject.cpp b/src/server/game/Entities/GameObject/GameObject.cpp index cd3ebd306ea..12cdbe445fb 100644 --- a/src/server/game/Entities/GameObject/GameObject.cpp +++ b/src/server/game/Entities/GameObject/GameObject.cpp @@ -2730,5 +2730,5 @@ private: GameObjectModel* GameObject::CreateModel() { - return GameObjectModel::Create(Trinity::make_unique(this), sWorld->GetDataPath()); + return GameObjectModel::Create(std::make_unique(this), sWorld->GetDataPath()); } diff --git a/src/server/game/Entities/Player/CollectionMgr.cpp b/src/server/game/Entities/Player/CollectionMgr.cpp index a715ea37b6a..e1fc18eee9c 100644 --- a/src/server/game/Entities/Player/CollectionMgr.cpp +++ b/src/server/game/Entities/Player/CollectionMgr.cpp @@ -85,7 +85,7 @@ namespace } } -CollectionMgr::CollectionMgr(WorldSession* owner) : _owner(owner), _appearances(Trinity::make_unique>()) +CollectionMgr::CollectionMgr(WorldSession* owner) : _owner(owner), _appearances(std::make_unique>()) { } diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp index 939d7e750d1..cbf315cf6a5 100644 --- a/src/server/game/Entities/Player/Player.cpp +++ b/src/server/game/Entities/Player/Player.cpp @@ -346,14 +346,14 @@ Player::Player(WorldSession* session) : Unit(true), m_sceneMgr(this) m_achievementMgr = new PlayerAchievementMgr(this); m_reputationMgr = new ReputationMgr(this); - m_questObjectiveCriteriaMgr = Trinity::make_unique(this); + m_questObjectiveCriteriaMgr = std::make_unique(this); for (uint8 i = 0; i < MAX_CUF_PROFILES; ++i) _CUFProfiles[i] = nullptr; _advancedCombatLoggingEnabled = false; - _restMgr = Trinity::make_unique(this); + _restMgr = std::make_unique(this); _usePvpItemLevels = false; } @@ -18645,7 +18645,7 @@ bool Player::LoadFromDB(ObjectGuid guid, CharacterDatabaseQueryHolder* holder) _LoadCUFProfiles(holder->GetPreparedResult(PLAYER_LOGIN_QUERY_LOAD_CUF_PROFILES)); - std::unique_ptr garrison = Trinity::make_unique(this); + std::unique_ptr garrison = std::make_unique(this); if (garrison->LoadFromDB(holder->GetPreparedResult(PLAYER_LOGIN_QUERY_LOAD_GARRISON), holder->GetPreparedResult(PLAYER_LOGIN_QUERY_LOAD_GARRISON_BLUEPRINTS), holder->GetPreparedResult(PLAYER_LOGIN_QUERY_LOAD_GARRISON_BUILDINGS), @@ -18704,7 +18704,7 @@ void Player::_LoadCUFProfiles(PreparedQueryResult result) continue; } - _CUFProfiles[id] = Trinity::make_unique(name, frameHeight, frameWidth, sortBy, healthText, boolOptions, topPoint, bottomPoint, leftPoint, topOffset, bottomOffset, leftOffset); + _CUFProfiles[id] = std::make_unique(name, frameHeight, frameWidth, sortBy, healthText, boolOptions, topPoint, bottomPoint, leftPoint, topOffset, bottomOffset, leftOffset); } while (result->NextRow()); } diff --git a/src/server/game/Entities/Unit/Unit.cpp b/src/server/game/Entities/Unit/Unit.cpp index 6d5b164f594..76a181ac0bf 100644 --- a/src/server/game/Entities/Unit/Unit.cpp +++ b/src/server/game/Entities/Unit/Unit.cpp @@ -14095,7 +14095,7 @@ void Unit::SendSetVehicleRecId(uint32 vehicleId) void Unit::ApplyMovementForce(ObjectGuid id, Position origin, float magnitude, uint8 type, Position direction /*= {}*/, ObjectGuid transportGuid /*= ObjectGuid::Empty*/) { if (!_movementForces) - _movementForces = Trinity::make_unique(); + _movementForces = std::make_unique(); MovementForce force; force.ID = id; @@ -14208,7 +14208,7 @@ void Unit::UpdateMovementForcesModMagnitude() } if (modMagnitude != 1.0f && !_movementForces) - _movementForces = Trinity::make_unique(); + _movementForces = std::make_unique(); if (_movementForces) { diff --git a/src/server/game/Globals/ObjectMgr.h b/src/server/game/Globals/ObjectMgr.h index 22a65795177..1bcf58a452d 100644 --- a/src/server/game/Globals/ObjectMgr.h +++ b/src/server/game/Globals/ObjectMgr.h @@ -1635,7 +1635,7 @@ class TC_GAME_API ObjectMgr { auto itr = _guidGenerators.find(high); if (itr == _guidGenerators.end()) - itr = _guidGenerators.insert(std::make_pair(high, Trinity::make_unique>())).first; + itr = _guidGenerators.insert(std::make_pair(high, std::make_unique>())).first; return *itr->second; } diff --git a/src/server/game/Groups/Group.cpp b/src/server/game/Groups/Group.cpp index 0ce01460161..cca640eb97c 100644 --- a/src/server/game/Groups/Group.cpp +++ b/src/server/game/Groups/Group.cpp @@ -2385,7 +2385,7 @@ void Group::AddRaidMarker(uint8 markerId, uint32 mapId, float positionX, float p return; m_activeMarkers |= (1 << markerId); - m_markers[markerId] = Trinity::make_unique(mapId, positionX, positionY, positionZ, transportGuid); + m_markers[markerId] = std::make_unique(mapId, positionX, positionY, positionZ, transportGuid); SendRaidMarkersChanged(); } diff --git a/src/server/game/Maps/Map.cpp b/src/server/game/Maps/Map.cpp index 5e00ed3b83e..1406014504f 100644 --- a/src/server/game/Maps/Map.cpp +++ b/src/server/game/Maps/Map.cpp @@ -4381,7 +4381,7 @@ Weather* Map::GetOrGenerateZoneDefaultWeather(uint32 zoneId) ZoneDynamicInfo& info = _zoneDynamicInfo[zoneId]; if (!info.DefaultWeather) { - info.DefaultWeather = Trinity::make_unique(zoneId, weatherData); + info.DefaultWeather = std::make_unique(zoneId, weatherData); info.DefaultWeather->ReGenerate(); info.DefaultWeather->UpdateWeather(); } diff --git a/src/server/game/Maps/Map.h b/src/server/game/Maps/Map.h index 396867684f9..d1cf310262d 100644 --- a/src/server/game/Maps/Map.h +++ b/src/server/game/Maps/Map.h @@ -747,7 +747,7 @@ class TC_GAME_API Map : public GridRefManager { auto itr = _guidGenerators.find(high); if (itr == _guidGenerators.end()) - itr = _guidGenerators.insert(std::make_pair(high, Trinity::make_unique>())).first; + itr = _guidGenerators.insert(std::make_pair(high, std::make_unique>())).first; return *itr->second; } diff --git a/src/server/game/Scripting/ScriptMgr.cpp b/src/server/game/Scripting/ScriptMgr.cpp index 72354f47b21..668f4bba387 100644 --- a/src/server/game/Scripting/ScriptMgr.cpp +++ b/src/server/game/Scripting/ScriptMgr.cpp @@ -243,7 +243,7 @@ public: void QueueForDelayedDelete(T&& any) { _delayed_delete_queue.push_back( - Trinity::make_unique< + std::make_unique< DeleteableObject::type> >(std::forward(any)) ); diff --git a/src/server/game/Scripting/ScriptReloadMgr.cpp b/src/server/game/Scripting/ScriptReloadMgr.cpp index 18f1135128e..b8cc437ecb7 100644 --- a/src/server/game/Scripting/ScriptReloadMgr.cpp +++ b/src/server/game/Scripting/ScriptReloadMgr.cpp @@ -936,7 +936,7 @@ private: } // Create the source listener - auto listener = Trinity::make_unique( + auto listener = std::make_unique( sScriptReloadMgr->GetSourceDirectory() / module_name, module_name); diff --git a/src/server/game/Server/Packets/AuthenticationPackets.cpp b/src/server/game/Server/Packets/AuthenticationPackets.cpp index f0eb8b58dd0..b69f7b1c3ab 100644 --- a/src/server/game/Server/Packets/AuthenticationPackets.cpp +++ b/src/server/game/Server/Packets/AuthenticationPackets.cpp @@ -240,7 +240,7 @@ std::unique_ptr ConnectToRSA; bool WorldPackets::Auth::ConnectTo::InitializeEncryption() { - std::unique_ptr rsa = Trinity::make_unique(); + std::unique_ptr rsa = std::make_unique(); if (!rsa->LoadFromString(RSAPrivateKey, Trinity::Crypto::RSA::PrivateKey{})) return false; diff --git a/src/server/game/Server/Packets/MiscPackets.cpp b/src/server/game/Server/Packets/MiscPackets.cpp index a1bd2a25598..48a1d4ac78a 100644 --- a/src/server/game/Server/Packets/MiscPackets.cpp +++ b/src/server/game/Server/Packets/MiscPackets.cpp @@ -502,7 +502,7 @@ void WorldPackets::Misc::SaveCUFProfiles::Read() CUFProfiles.resize(_worldPacket.read()); for (std::unique_ptr& cufProfile : CUFProfiles) { - cufProfile = Trinity::make_unique(); + cufProfile = std::make_unique(); uint8 strLen = _worldPacket.ReadBits(7); diff --git a/src/server/game/Server/WorldSession.cpp b/src/server/game/Server/WorldSession.cpp index 1c9f49df88b..5ca01aa520b 100644 --- a/src/server/game/Server/WorldSession.cpp +++ b/src/server/game/Server/WorldSession.cpp @@ -134,8 +134,8 @@ WorldSession::WorldSession(uint32 id, std::string&& name, uint32 battlenetAccoun expireTime(60000), // 1 min after socket loss, session is deleted forceExit(false), m_currentBankerGUID(), - _battlePetMgr(Trinity::make_unique(this)), - _collectionMgr(Trinity::make_unique(this)) + _battlePetMgr(std::make_unique(this)), + _collectionMgr(std::make_unique(this)) { memset(_tutorials, 0, sizeof(_tutorials)); diff --git a/src/server/game/Spells/Spell.cpp b/src/server/game/Spells/Spell.cpp index e9f01061f75..23ebb5314ff 100644 --- a/src/server/game/Spells/Spell.cpp +++ b/src/server/game/Spells/Spell.cpp @@ -5382,7 +5382,7 @@ SpellCastResult Spell::CheckCast(bool strict, uint32* param1 /*= nullptr*/, uint float objSize = target->GetCombatReach(); float range = m_spellInfo->GetMaxRange(true, m_caster, this) * 1.5f + objSize; // can't be overly strict - m_preGeneratedPath = Trinity::make_unique(m_caster); + m_preGeneratedPath = std::make_unique(m_caster); m_preGeneratedPath->SetPathLengthLimit(range); // first try with raycast, if it fails fall back to normal path float targetObjectSize = std::min(target->GetCombatReach(), 4.0f); diff --git a/src/server/shared/Realm/RealmList.cpp b/src/server/shared/Realm/RealmList.cpp index 3ce8c8f2f4e..ca591e423f5 100644 --- a/src/server/shared/Realm/RealmList.cpp +++ b/src/server/shared/Realm/RealmList.cpp @@ -35,7 +35,7 @@ RealmList::RealmList() : _updateInterval(0) { - _realmsMutex = Trinity::make_unique(); + _realmsMutex = std::make_unique(); } RealmList::~RealmList() @@ -52,8 +52,8 @@ RealmList* RealmList::Instance() void RealmList::Initialize(Trinity::Asio::IoContext& ioContext, uint32 updateInterval) { _updateInterval = updateInterval; - _updateTimer = Trinity::make_unique(ioContext); - _resolver = Trinity::make_unique(ioContext); + _updateTimer = std::make_unique(ioContext); + _resolver = std::make_unique(ioContext); LoadBuildInfo(); // Get the content of the realmlist table in the database @@ -112,11 +112,11 @@ void RealmList::UpdateRealm(Realm& realm, Battlenet::RealmHandle const& id, uint realm.AllowedSecurityLevel = allowedSecurityLevel; realm.PopulationLevel = population; if (!realm.ExternalAddress || *realm.ExternalAddress != address) - realm.ExternalAddress = Trinity::make_unique(std::move(address)); + realm.ExternalAddress = std::make_unique(std::move(address)); if (!realm.LocalAddress || *realm.LocalAddress != localAddr) - realm.LocalAddress = Trinity::make_unique(std::move(localAddr)); + realm.LocalAddress = std::make_unique(std::move(localAddr)); if (!realm.LocalSubnetMask || *realm.LocalSubnetMask != localSubmask) - realm.LocalSubnetMask = Trinity::make_unique(std::move(localSubmask)); + realm.LocalSubnetMask = std::make_unique(std::move(localSubmask)); realm.Port = port; } diff --git a/src/server/worldserver/Main.cpp b/src/server/worldserver/Main.cpp index 65f30acce7a..a43663775ef 100644 --- a/src/server/worldserver/Main.cpp +++ b/src/server/worldserver/Main.cpp @@ -516,9 +516,9 @@ bool LoadRealmInfo() { realm.Id = realmListRealm->Id; realm.Build = realmListRealm->Build; - realm.ExternalAddress = Trinity::make_unique(*realmListRealm->ExternalAddress); - realm.LocalAddress = Trinity::make_unique(*realmListRealm->LocalAddress); - realm.LocalSubnetMask = Trinity::make_unique(*realmListRealm->LocalSubnetMask); + realm.ExternalAddress = std::make_unique(*realmListRealm->ExternalAddress); + realm.LocalAddress = std::make_unique(*realmListRealm->LocalAddress); + realm.LocalSubnetMask = std::make_unique(*realmListRealm->LocalSubnetMask); realm.Port = realmListRealm->Port; realm.Name = realmListRealm->Name; realm.NormalizedName = realmListRealm->NormalizedName; -- cgit v1.2.3