From eda48550f227c7144810db6ac7bb9116090bdfd1 Mon Sep 17 00:00:00 2001 From: Shauren Date: Fri, 1 Nov 2019 11:15:35 +0100 Subject: Core/PacketIO: Fixed quest log updatefield packet structure --- src/server/game/Entities/Object/Updates/UpdateFields.cpp | 14 +++++++------- src/server/game/Entities/Object/Updates/UpdateFields.h | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'src/server') diff --git a/src/server/game/Entities/Object/Updates/UpdateFields.cpp b/src/server/game/Entities/Object/Updates/UpdateFields.cpp index c9c7dcd3191..0f0e45a3696 100644 --- a/src/server/game/Entities/Object/Updates/UpdateFields.cpp +++ b/src/server/game/Entities/Object/Updates/UpdateFields.cpp @@ -1915,7 +1915,7 @@ void PlayerData::WriteUpdate(ByteBuffer& data, UpdateMask<192> const& changesMas if (changesMask.GetBlock(i)) data.WriteBits(changesMask.GetBlock(i), 32); - bool hasQuestLogDynamicChangesMask = data.WriteBit(IsQuestLogDynamicChangesMask()); + bool noQuestLogChangesMask = data.WriteBit(IsQuestLogChangesMaskSkipped()); if (changesMask[0]) { if (changesMask[1]) @@ -1944,10 +1944,10 @@ void PlayerData::WriteUpdate(ByteBuffer& data, UpdateMask<192> const& changesMas { if (QuestSessionQuestLog.HasChanged(i)) { - if (hasQuestLogDynamicChangesMask) - QuestSessionQuestLog[i].WriteUpdate(data, owner, receiver); - else + if (noQuestLogChangesMask) QuestSessionQuestLog[i].WriteCreate(data, owner, receiver); + else + QuestSessionQuestLog[i].WriteUpdate(data, owner, receiver); } } } @@ -2105,10 +2105,10 @@ void PlayerData::WriteUpdate(ByteBuffer& data, UpdateMask<192> const& changesMas { if (changesMask[42 + i]) { - if (hasQuestLogDynamicChangesMask) - QuestLog[i].WriteUpdate(data, owner, receiver); - else + if (noQuestLogChangesMask) QuestLog[i].WriteCreate(data, owner, receiver); + else + QuestLog[i].WriteUpdate(data, owner, receiver); } } } diff --git a/src/server/game/Entities/Object/Updates/UpdateFields.h b/src/server/game/Entities/Object/Updates/UpdateFields.h index b519b79a625..dcc4cb15076 100644 --- a/src/server/game/Entities/Object/Updates/UpdateFields.h +++ b/src/server/game/Entities/Object/Updates/UpdateFields.h @@ -417,7 +417,7 @@ struct PlayerData : public IsUpdateFieldStructureTag, public HasChangesMask<192> void AppendAllowedFieldsMaskForFlag(UpdateMask<192>& allowedMaskForTarget, EnumClassFlag fieldVisibilityFlags) const; void WriteUpdate(ByteBuffer& data, UpdateMask<192> const& changesMask, EnumClassFlag fieldVisibilityFlags, Player const* owner, Player const* receiver) const; void ClearChangesMask(); - bool IsQuestLogDynamicChangesMask() const { return false; } // bandwidth savings aren't worth the cpu time + bool IsQuestLogChangesMaskSkipped() const { return false; } // bandwidth savings aren't worth the cpu time }; struct SkillInfo : public IsUpdateFieldStructureTag, public HasChangesMask<1793> -- cgit v1.2.3