From 5e48be89d5cb3eb15e41fb0120e5ee979de73271 Mon Sep 17 00:00:00 2001 From: Machiavelli Date: Thu, 13 May 2010 14:22:00 +0200 Subject: Fix a crash in SqlAsyncTask::call caused by the fact that the SQLOperation to be called was a NULL pointer. The crash was mostly noticable on servers with relatively high MapUpdate Threads, since the window between SqlAsyncTask::call()´s NULLpointer check for m_op and the usage of this pointer was larger when more map threads are calling Database::CommitTransaction()´s and NULLing this pointer. Fixes crash specified in comment #24 in issue #1259, and most likely will affect other crashes specified there as well. Courtesy of click and myself, and our lengthy and deep brainstorming session. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --HG-- branch : trunk --- src/shared/Database/Database.cpp | 1 - 1 file changed, 1 deletion(-) (limited to 'src/shared/Database/Database.cpp') diff --git a/src/shared/Database/Database.cpp b/src/shared/Database/Database.cpp index bc4e863132e..d03f8704896 100644 --- a/src/shared/Database/Database.cpp +++ b/src/shared/Database/Database.cpp @@ -591,7 +591,6 @@ bool Database::CommitTransaction() if (i != m_tranQueues.end() && i->second != NULL) { m_threadBody->Delay(i->second); - i->second = NULL; return true; } else -- cgit v1.2.3