From 699bc588b86a5176fce0900804fb7d00425383fe Mon Sep 17 00:00:00 2001 From: megamage Date: Tue, 24 Feb 2009 11:14:28 -0600 Subject: [7330] Code warnings and style cleanups. Some bugs fixes. Author: VladimirMangos 1) comparison singed and unsigned values 2) redundent includes 3) wrong constructor :-part field initilization 4) unused not-/*name*/-guarded args in template/virtual functions that not required like args. 5) explicitly list not implemented achievement types. Also bugs fixed: 1) Drop wrong phase mask 0 check in WorldObject::InSamePhase. 2) ArenaTeamMember::ModifyPersonalRating incorrect work with move points in negative with infinity values in result. 3) ArenaTeam::SaveToDB code send uint64 value to string with arg format %u. --HG-- branch : trunk --- src/shared/Database/SQLStorageImpl.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/shared/Database/SQLStorageImpl.h') diff --git a/src/shared/Database/SQLStorageImpl.h b/src/shared/Database/SQLStorageImpl.h index 6cb67832f02..b7927851fef 100644 --- a/src/shared/Database/SQLStorageImpl.h +++ b/src/shared/Database/SQLStorageImpl.h @@ -22,13 +22,13 @@ template template -void SQLStorageLoaderBase::convert(uint32 field_pos, S src, D &dst) +void SQLStorageLoaderBase::convert(uint32 /*field_pos*/, S src, D &dst) { dst = D(src); } template -void SQLStorageLoaderBase::convert_str_to_str(uint32 field_pos, char *src, char *&dst) +void SQLStorageLoaderBase::convert_str_to_str(uint32 /*field_pos*/, char *src, char *&dst) { if(!src) { @@ -45,7 +45,7 @@ void SQLStorageLoaderBase::convert_str_to_str(uint32 field_pos, char *src, ch template template -void SQLStorageLoaderBase::convert_to_str(uint32 field_pos, S src, char * & dst) +void SQLStorageLoaderBase::convert_to_str(uint32 /*field_pos*/, S /*src*/, char * & dst) { dst = new char[1]; *dst = 0; @@ -53,7 +53,7 @@ void SQLStorageLoaderBase::convert_to_str(uint32 field_pos, S src, char * & d template template -void SQLStorageLoaderBase::convert_from_str(uint32 field_pos, char * src, D& dst) +void SQLStorageLoaderBase::convert_from_str(uint32 /*field_pos*/, char * /*src*/, D& dst) { dst = 0; } -- cgit v1.2.3