From 03f98136fefb4d1b70852e7090bd2fa6ba511892 Mon Sep 17 00:00:00 2001 From: Ovahlord Date: Fri, 20 Dec 2024 16:44:29 +0100 Subject: Core/Player: rename IsBaseRuneSlotsOnCooldown to IsRuneFullyDepleted to match the wording used in Runic Empowerment's tooltip --- src/server/game/Entities/Player/Player.cpp | 2 +- src/server/game/Entities/Player/Player.h | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp index 0a6bb78d393..cd601d51c98 100644 --- a/src/server/game/Entities/Player/Player.cpp +++ b/src/server/game/Entities/Player/Player.cpp @@ -25306,7 +25306,7 @@ Powers Player::GetPowerTypeForBaseRune(uint8 index) const } } -bool Player::IsBaseRuneSlotsOnCooldown(RuneType runeType) const +bool Player::IsRuneFullyDepleted(RuneType runeType) const { for (uint8 i = 0; i < MAX_RUNES; ++i) if (GetBaseRune(i) == runeType && G3D::fuzzyEq(GetRuneCooldown(i), 0.0f)) diff --git a/src/server/game/Entities/Player/Player.h b/src/server/game/Entities/Player/Player.h index affe00693b7..359748161da 100644 --- a/src/server/game/Entities/Player/Player.h +++ b/src/server/game/Entities/Player/Player.h @@ -2604,7 +2604,12 @@ class TC_GAME_API Player final : public Unit, public GridObject RuneType GetCurrentRune(uint8 index) const { return RuneType(m_runes->_Runes[index].CurrentRune); } Powers GetPowerTypeForBaseRune(uint8 index) const; float GetRuneCooldown(uint8 index) const { return m_runes->_Runes[index].Cooldown; } - bool IsBaseRuneSlotsOnCooldown(RuneType runeType) const; + /// + /// Iterates over all player runes and checks if all base runes of the specified type are on cooldown. + /// + /// The kind of base rune that is being checked (Blood, Unholy, Frost). Death Runes are no base rune and can't be checked with this method. Use the underlying base rune instead. + /// true when all base runes of the specified type are on cooldown + bool IsRuneFullyDepleted(RuneType runeType) const; RuneType GetLastUsedRune() { return m_runes->LastUsedRune; } uint8 GetLastUsedRuneMask() { return m_runes->LastUsedRuneMask; } void ClearLastUsedRuneMask() { m_runes->LastUsedRuneMask = 0; } -- cgit v1.2.3