From 063e89d07d3905d03729dc6163ecc7690668d3f6 Mon Sep 17 00:00:00 2001
From: Shauren <none@none>
Date: Sat, 9 Oct 2010 18:07:27 +0200
Subject: Core/Guild: Fixed crash when unstacking items in guild bank

Closes issue #4360.

--HG--
branch : trunk
---
 src/server/game/Entities/Item/Item.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'src')

diff --git a/src/server/game/Entities/Item/Item.cpp b/src/server/game/Entities/Item/Item.cpp
index 3dea6a61958..8dcce98c040 100755
--- a/src/server/game/Entities/Item/Item.cpp
+++ b/src/server/game/Entities/Item/Item.cpp
@@ -1060,7 +1060,9 @@ Item* Item::CloneItem(uint32 count, Player const* player) const
     newItem->SetUInt32Value(ITEM_FIELD_GIFTCREATOR,  GetUInt32Value(ITEM_FIELD_GIFTCREATOR));
     newItem->SetUInt32Value(ITEM_FIELD_FLAGS,        GetUInt32Value(ITEM_FIELD_FLAGS));
     newItem->SetUInt32Value(ITEM_FIELD_DURATION,     GetUInt32Value(ITEM_FIELD_DURATION));
-    newItem->SetItemRandomProperties(GetItemRandomPropertyId());
+    // player CAN be NULL in which case we must not update random properties because that accesses player's item update queue
+    if (player)
+        newItem->SetItemRandomProperties(GetItemRandomPropertyId());
     return newItem;
 }
 
-- 
cgit v1.2.3