From 3bcda5acf4564b662db4dfde0af7279f99a93b79 Mon Sep 17 00:00:00 2001 From: Peter Keresztes Schmidt Date: Sat, 3 Jul 2021 12:08:30 +0200 Subject: Scripts/SholazarBasin: Fix a possible nullptr dereference issue found by coverity (#26648) --- src/server/scripts/Northrend/zone_sholazar_basin.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/server/scripts/Northrend/zone_sholazar_basin.cpp b/src/server/scripts/Northrend/zone_sholazar_basin.cpp index 723dd0d75de..941832c59bb 100644 --- a/src/server/scripts/Northrend/zone_sholazar_basin.cpp +++ b/src/server/scripts/Northrend/zone_sholazar_basin.cpp @@ -130,7 +130,10 @@ class spell_q12688_detonate_1 : public SpellScript target->GetMap()->SpawnGroupSpawn(SPAWN_GROUP_FLAMES, false, false, &flames); target->GetMap()->SetSpawnGroupInactive(SPAWN_GROUP_FLAMES); for (WorldObject* flame : flames) - dynamic_cast(flame)->DespawnOrUnsummon(20s); + { + if (GameObject* flame_go = flame->ToGameObject()) + flame_go->DespawnOrUnsummon(20s); + } } } @@ -168,7 +171,10 @@ class spell_q12688_detonate_2 : public SpellScript target->GetMap()->SpawnGroupSpawn(SPAWN_GROUP_FLAMES, false, false, &flames); target->GetMap()->SetSpawnGroupInactive(SPAWN_GROUP_FLAMES); for (WorldObject* flame : flames) - dynamic_cast(flame)->DespawnOrUnsummon(20s); + { + if (GameObject* flame_go = flame->ToGameObject()) + flame_go->DespawnOrUnsummon(20s); + } } } -- cgit v1.2.3