From 3f479399695ce4aed7f508be46cfdccfd4353eee Mon Sep 17 00:00:00 2001 From: Shauren Date: Sat, 27 Mar 2021 00:25:50 +0100 Subject: Core/Auras: Corrected logic used to determine if a spellmod should affect another spell, empty family name or class mask should not apply to any spell --- src/server/game/Spells/SpellInfo.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/server/game/Spells/SpellInfo.cpp b/src/server/game/Spells/SpellInfo.cpp index 0a73ed4ad1f..64652d6474b 100644 --- a/src/server/game/Spells/SpellInfo.cpp +++ b/src/server/game/Spells/SpellInfo.cpp @@ -1754,7 +1754,9 @@ bool SpellInfo::IsAffectedBySpellMod(SpellModifier const* mod) const if (!affectSpell) return false; - return IsAffected(affectSpell->SpellFamilyName, mod->mask); + // TEMP: dont use IsAffected - !familyName and !familyFlags are not valid options for spell mods + // TODO: investigate if the !familyName and !familyFlags conditions are even valid for all other (nonmod) uses of SpellInfo::IsAffected + return affectSpell->SpellFamilyName == SpellFamilyName && mod->mask & SpellFamilyFlags; } bool SpellInfo::CanPierceImmuneAura(SpellInfo const* auraSpellInfo) const -- cgit v1.2.3