From 722bd7e0e593d84892dcbd356d79d8ee0a626740 Mon Sep 17 00:00:00 2001 From: Chaouki Dhib Date: Sun, 4 Jul 2021 22:25:37 +0200 Subject: Core/Movement: Add missing change to the unit validation of ACK handlers --- src/server/game/Handlers/MovementHandler.cpp | 30 ++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/server/game/Handlers/MovementHandler.cpp b/src/server/game/Handlers/MovementHandler.cpp index f5ad01e1c3c..13009d81cd6 100644 --- a/src/server/game/Handlers/MovementHandler.cpp +++ b/src/server/game/Handlers/MovementHandler.cpp @@ -690,7 +690,8 @@ void WorldSession::HandleMoveHoverAck(WorldPacket& recvData) ObjectGuid guid; // guid - unused recvData >> guid.ReadAsPacked(); - if (!IsRightUnitBeingMoved(guid)) + GameClient* client = GetGameClient(); + if (!client->IsAllowedToMove(guid)) { recvData.rfinish(); // prevent warnings spam return; @@ -712,7 +713,8 @@ void WorldSession::HandleMoveWaterWalkAck(WorldPacket& recvData) ObjectGuid guid; // guid - unused recvData >> guid.ReadAsPacked(); - if (!IsRightUnitBeingMoved(guid)) + GameClient* client = GetGameClient(); + if (!client->IsAllowedToMove(guid)) { recvData.rfinish(); // prevent warnings spam return; @@ -734,7 +736,8 @@ void WorldSession::HandleMoveRootAck(WorldPacket& recvData) ObjectGuid guid; // guid - unused recvData >> guid.ReadAsPacked(); - if (!IsRightUnitBeingMoved(guid)) + GameClient* client = GetGameClient(); + if (!client->IsAllowedToMove(guid)) { recvData.rfinish(); // prevent warnings spam return; @@ -754,7 +757,8 @@ void WorldSession::HandleFeatherFallAck(WorldPacket& recvData) ObjectGuid guid; // guid - unused recvData >> guid.ReadAsPacked(); - if (!IsRightUnitBeingMoved(guid)) + GameClient* client = GetGameClient(); + if (!client->IsAllowedToMove(guid)) { recvData.rfinish(); // prevent warnings spam return; @@ -776,7 +780,8 @@ void WorldSession::HandleMoveUnRootAck(WorldPacket& recvData) ObjectGuid guid; // guid - unused recvData >> guid.ReadAsPacked(); - if (!IsRightUnitBeingMoved(guid)) + GameClient* client = GetGameClient(); + if (!client->IsAllowedToMove(guid)) { recvData.rfinish(); // prevent warnings spam return; @@ -796,7 +801,8 @@ void WorldSession::HandleMoveSetCanFlyAckOpcode(WorldPacket& recvData) ObjectGuid guid; // guid - unused recvData >> guid.ReadAsPacked(); - if (!IsRightUnitBeingMoved(guid)) + GameClient* client = GetGameClient(); + if (!client->IsAllowedToMove(guid)) { recvData.rfinish(); // prevent warnings spam return; @@ -818,7 +824,8 @@ void WorldSession::HandleMoveSetCanTransitionBetweenSwinAndFlyAck(WorldPacket& r ObjectGuid guid; recvData >> guid.ReadAsPacked(); - if (!IsRightUnitBeingMoved(guid)) + GameClient* client = GetGameClient(); + if (!client->IsAllowedToMove(guid)) { recvData.rfinish(); // prevent warnings spam return; @@ -840,7 +847,8 @@ void WorldSession::HandleMoveGravityDisableAck(WorldPacket& recvData) ObjectGuid guid; recvData >> guid.ReadAsPacked(); - if (!IsRightUnitBeingMoved(guid)) + GameClient* client = GetGameClient(); + if (!client->IsAllowedToMove(guid)) { recvData.rfinish(); // prevent warnings spam return; @@ -860,7 +868,8 @@ void WorldSession::HandleMoveGravityEnableAck(WorldPacket& recvData) ObjectGuid guid; recvData >> guid.ReadAsPacked(); - if (!IsRightUnitBeingMoved(guid)) + GameClient* client = GetGameClient(); + if (!client->IsAllowedToMove(guid)) { recvData.rfinish(); // prevent warnings spam return; @@ -881,7 +890,8 @@ void WorldSession::HandleMoveSetCollisionHgtAck(WorldPacket& recvData) float newValue; recvData >> guid.ReadAsPacked(); - if (!IsRightUnitBeingMoved(guid)) + GameClient* client = GetGameClient(); + if (!client->IsAllowedToMove(guid)) { recvData.rfinish(); // prevent warnings spam return; -- cgit v1.2.3