From 95b194f3f8b49d4b34997ee8ccba5f36d001d4af Mon Sep 17 00:00:00 2001
From: Seyden <saiifii@live.de>
Date: Thu, 23 Nov 2017 22:35:42 +0100
Subject: Core/Auras: Fixed rppm proc chance calculation (#20962)

* LastAttemptTime was reseted before it could have been taken into account for chance calculation
---
 src/server/game/Spells/Auras/SpellAuras.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'src')

diff --git a/src/server/game/Spells/Auras/SpellAuras.cpp b/src/server/game/Spells/Auras/SpellAuras.cpp
index 57c668bb8b6..3f4287becd7 100644
--- a/src/server/game/Spells/Auras/SpellAuras.cpp
+++ b/src/server/game/Spells/Auras/SpellAuras.cpp
@@ -1799,9 +1799,11 @@ uint32 Aura::IsProcTriggeredOnEvent(AuraApplication* aurApp, ProcEventInfo& even
         }
     }
 
+    bool success = roll_chance_f(CalcProcChance(*procEntry, eventInfo));
+
     const_cast<Aura*>(this)->SetLastProcAttemptTime(now);
 
-    if (roll_chance_f(CalcProcChance(*procEntry, eventInfo)))
+    if (success)
         return procEffectMask;
 
     return 0;
-- 
cgit v1.2.3