From a36d4fc7aefe9fff8def7bf9ffd6185a8291eb06 Mon Sep 17 00:00:00 2001
From: megamage <none@none>
Date: Sun, 31 May 2009 16:01:19 -0500
Subject: [7917] Spell effect with SPELL_AURA_MOD_SPELL_CRIT_CHANCE always
 possitive with possitive aura value. Author: VladimirMangos

--HG--
branch : trunk
---
 src/game/SpellMgr.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

(limited to 'src')

diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp
index 5dd2010b83b..6fb3d8cfc55 100644
--- a/src/game/SpellMgr.cpp
+++ b/src/game/SpellMgr.cpp
@@ -620,11 +620,13 @@ bool IsPositiveEffect(uint32 spellId, uint32 effIndex, bool deep)
                 case SPELL_AURA_MOD_DAMAGE_DONE:            // dependent from bas point sign (negative -> negative)
                 case SPELL_AURA_MOD_HEALING_DONE:
                 case SPELL_AURA_MOD_DAMAGE_PERCENT_DONE:
-                {
                     if(spellproto->CalculateSimpleValue(effIndex) < 0)
                         return false;
                     break;
-                }
+                case SPELL_AURA_MOD_SPELL_CRIT_CHANCE:
+                    if(spellproto->CalculateSimpleValue(effIndex) > 0)
+                        return true;                        // some expected possitive spells have SPELL_ATTR_EX_NEGATIVE
+                    break;
                 case SPELL_AURA_ADD_TARGET_TRIGGER:
                     return true;
                 case SPELL_AURA_PERIODIC_TRIGGER_SPELL_WITH_VALUE:
-- 
cgit v1.2.3