From 7a0c2fc4f7832398a2276c1f916727f15b36c9f3 Mon Sep 17 00:00:00 2001 From: Unholychick Date: Tue, 8 Apr 2014 12:36:33 +0200 Subject: Fix SPELL_DAMAGE_CLASS_NONE unable to crit Corrected logic mistake where switch fallthrough was intended (or should have been). Fixes the following. // Earth Shield // Lifebloom Final Bloom // Divine Hymn // Item - Bauble of True Blood 10m // Item - Bauble of True Blood 25m --- src/server/game/Entities/Unit/Unit.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/server/game/Entities/Unit/Unit.cpp b/src/server/game/Entities/Unit/Unit.cpp index d389ab47725..5bf3193fc14 100644 --- a/src/server/game/Entities/Unit/Unit.cpp +++ b/src/server/game/Entities/Unit/Unit.cpp @@ -10443,7 +10443,7 @@ bool Unit::isSpellCrit(Unit* victim, SpellInfo const* spellProto, SpellSchoolMas default: return false; } - break; + // Do not add a break here, case fallthrough is intentional! Adding a break will make above spells unable to crit. case SPELL_DAMAGE_CLASS_MAGIC: { if (schoolMask & SPELL_SCHOOL_MASK_NORMAL) -- cgit v1.2.3