From 0450b74e9682c67f69d2c85985251d9234797a9b Mon Sep 17 00:00:00 2001 From: jackpoz Date: Tue, 3 Sep 2013 23:05:02 +0200 Subject: Core/Movement: Fix uninitialized MovementInfo fields Fix uninitialized fallTime and splineElevation fields of MovementInfo. Valgrind log: Conditional jump or move depends on uninitialised value(s) at 0x5FBEB50: deflate (in /lib/x86_64-linux-gnu/libz.so.1.2.7) by 0x1269883: UpdateData::Compress(void*, unsigned int*, void*, int) (UpdateData.cpp:85) by 0x1269BB6: UpdateData::BuildPacket(WorldPacket*) (UpdateData.cpp:133) by 0x130E9B3: Trinity::VisibleNotifier::SendToSelf() (GridNotifiers.cpp:68) by 0x117A89D: Player::UpdateVisibilityForPlayer() (Player.cpp:22344) by 0x117B334: Player::SendInitialPacketsAfterAddToMap() (Player.cpp:22567) by 0x15A48BC: WorldSession::HandlePlayerLogin(LoginQueryHolder*) (CharacterHandler.cpp:937) by 0x141D04B: WorldSession::ProcessQueryCallbacks() (WorldSession.cpp:1106) by 0x141994D: WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:391) by 0x14E289C: World::UpdateSessions(unsigned int) (World.cpp:2629) by 0x14E0613: World::Update(unsigned int) (World.cpp:1986) by 0x100B37F: WorldRunnable::run() (WorldRunnable.cpp:60) Uninitialised value was created by a heap allocation at 0x4C286E7: operator new(unsigned long) (vg_replace_malloc.c:287) by 0x159E64F: void LoadHelper(std::set, std::allocator > const&, CoordPair<512u>&, GridRefManager&, unsigned int&, Map*) (ObjectGridLoader.cpp:94) by 0x159DECF: ObjectGridLoader::Visit(GridRefManager&) (ObjectGridLoader.cpp:150) by 0x159F092: void VisitorHelper(ObjectGridLoader&, ContainerMapList&) (TypeContainerVisitor.h:64) by 0x159EFF5: void VisitorHelper > >(ObjectGridLoader&, ContainerMapList > > >&) (TypeContainerVisitor.h:70) --- src/server/game/Entities/Object/Object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/server/game/Entities/Object/Object.h b/src/server/game/Entities/Object/Object.h index cb731bfe5e8..66b3a737e0c 100644 --- a/src/server/game/Entities/Object/Object.h +++ b/src/server/game/Entities/Object/Object.h @@ -450,7 +450,7 @@ struct MovementInfo float splineElevation; MovementInfo() : - guid(0), flags(0), flags2(0), time(0), pitch(0.0f) + guid(0), flags(0), flags2(0), time(0), pitch(0.0f), fallTime(0), splineElevation(0.0f) { pos.Relocate(0.0f, 0.0f, 0.0f, 0.0f); transport.Reset(); -- cgit v1.2.3