From b53cbf467b445a9b57a5567f88a26f77289f7fe1 Mon Sep 17 00:00:00 2001
From: Treeston <treeston.mmoc@gmail.com>
Date: Tue, 9 Jan 2018 23:55:57 +0100
Subject: 3dcd49e v2, slightly cheaper

---
 src/server/game/Combat/ThreatManager.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'src')

diff --git a/src/server/game/Combat/ThreatManager.cpp b/src/server/game/Combat/ThreatManager.cpp
index b7f1aec9854..c7e36557b30 100644
--- a/src/server/game/Combat/ThreatManager.cpp
+++ b/src/server/game/Combat/ThreatManager.cpp
@@ -333,10 +333,10 @@ void ThreatManager::AddThreat(Unit* target, float amount, SpellInfo const* spell
         if (!redirInfo.empty())
         {
             float const origAmount = amount;
-            // intentional copy - there's a nested AddThreat call further down that might cause AI calls which cast spells
-            auto const redirects = redirInfo;
-            for (auto const& pair : redirects) // (victim,pct)
+            // intentional iteration by index - there's a nested AddThreat call further down that might cause AI calls which might modify redirect info through spells
+            for (size_t i=0; i<redirInfo.size(); ++i)
             {
+                auto const pair = redirInfo[i]; // (victim,pct)
                 Unit* redirTarget = nullptr;
                 auto it = _myThreatListEntries.find(pair.first); // try to look it up in our threat list first (faster)
                 if (it != _myThreatListEntries.end())
-- 
cgit v1.2.3