From b61960c1a952b929c95a80b1269800ef30878e3d Mon Sep 17 00:00:00 2001 From: Shauren Date: Fri, 24 Jan 2025 23:03:39 +0100 Subject: Core/Spells: Prevent even more cases of sending aura update packets for auras that aren't visible on client (cherry picked from commit 380b1f8986c20803ae7d8c2387d31a2645a7e508) --- src/server/game/Spells/Auras/SpellAuras.cpp | 2 +- src/server/game/Spells/Spell.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/server/game/Spells/Auras/SpellAuras.cpp b/src/server/game/Spells/Auras/SpellAuras.cpp index ce52ff5232b..83000394a9b 100644 --- a/src/server/game/Spells/Auras/SpellAuras.cpp +++ b/src/server/game/Spells/Auras/SpellAuras.cpp @@ -231,7 +231,7 @@ void AuraApplication::AddEffectToApplyEffectMask(SpellEffIndex spellEffectIndex) void AuraApplication::SetNeedClientUpdate() { - if (_needClientUpdate || GetRemoveMode() != AURA_REMOVE_NONE) + if (_needClientUpdate || GetSlot() >= MAX_AURAS || GetRemoveMode() != AURA_REMOVE_NONE) return; _needClientUpdate = true; diff --git a/src/server/game/Spells/Spell.cpp b/src/server/game/Spells/Spell.cpp index 4295e709a4a..ed72a1d3366 100644 --- a/src/server/game/Spells/Spell.cpp +++ b/src/server/game/Spells/Spell.cpp @@ -3024,7 +3024,7 @@ void Spell::TargetInfo::DoDamageAndTriggers(Spell* spell) if (effMask) _spellHitTarget->_ApplyAura(aurApp, effMask); - if (aurApp->GetSlot() < MAX_AURAS && aurApp->IsNeedClientUpdate() && aurApp->GetRemoveMode() == AURA_REMOVE_NONE) + if (aurApp->IsNeedClientUpdate() && aurApp->GetRemoveMode() == AURA_REMOVE_NONE) { aurApp->ClientUpdate(false); _spellHitTarget->RemoveVisibleAuraUpdate(aurApp); -- cgit v1.2.3