From cc0a9d1fe96de7d59659c678814e6371be57774d Mon Sep 17 00:00:00 2001 From: Wyrserth Date: Wed, 17 Jul 2019 16:05:20 +0200 Subject: Core/Player: don't send errors to client from Satisfy* methods when Player::CanRewardQuest() is called with msg = false. Fixes cases where people would get strange errors like "You are not high enough level for that quest" when entering WotLK instances. (cherry picked from commit a4ddb30489d3c4cd96817232b28393c2f4e50595) --- src/server/game/Entities/Player/Player.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp index e8ae4bbdd49..e9ccab6cba9 100644 --- a/src/server/game/Entities/Player/Player.cpp +++ b/src/server/game/Entities/Player/Player.cpp @@ -15188,11 +15188,11 @@ bool Player::CanRewardQuest(Quest const* quest, bool msg) const return false; // daily quest can't be rewarded (25 daily quest already completed) - if (!SatisfyQuestDay(quest, true) || !SatisfyQuestWeek(quest, true) || !SatisfyQuestMonth(quest, true) || !SatisfyQuestSeasonal(quest, true)) + if (!SatisfyQuestDay(quest, msg) || !SatisfyQuestWeek(quest, msg) || !SatisfyQuestMonth(quest, msg) || !SatisfyQuestSeasonal(quest, msg)) return false; // player no longer satisfies the quest's requirements (skill level etc.) - if (!SatisfyQuestLevel(quest, true) || !SatisfyQuestSkill(quest, true) || !SatisfyQuestReputation(quest, true)) + if (!SatisfyQuestLevel(quest, msg) || !SatisfyQuestSkill(quest, msg) || !SatisfyQuestReputation(quest, msg)) return false; // rewarded and not repeatable quest (only cheating case, then ignore without message) -- cgit v1.2.3