From dce71612efa11bad7f25c65962d455843bd79baf Mon Sep 17 00:00:00 2001 From: Shauren Date: Sat, 25 Feb 2023 21:12:28 +0100 Subject: Core/Spells: Prevent rerolling gathering skillups until success when mining or gathering herbs (cherry picked from commit 92b7c98c018c1b950a45fb639e70871dca739ebd) --- src/server/game/Spells/SpellEffects.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/server/game/Spells/SpellEffects.cpp b/src/server/game/Spells/SpellEffects.cpp index 578a8d635b8..3b247b74095 100644 --- a/src/server/game/Spells/SpellEffects.cpp +++ b/src/server/game/Spells/SpellEffects.cpp @@ -1668,9 +1668,11 @@ void Spell::EffectOpenLock() if (gameObjTarget) { // Allow one skill-up until respawned - if (!gameObjTarget->IsInSkillupList(player->GetGUID()) && - player->UpdateGatherSkill(skillId, pureSkillValue, reqSkillValue, 1, gameObjTarget)) + if (!gameObjTarget->IsInSkillupList(player->GetGUID())) + { + player->UpdateGatherSkill(skillId, pureSkillValue, reqSkillValue, 1, gameObjTarget); gameObjTarget->AddToSkillupList(player->GetGUID()); + } } else if (itemTarget) { -- cgit v1.2.3