From e478434146fd479fab955aaa80eb925c15e29809 Mon Sep 17 00:00:00 2001 From: ariel- Date: Sun, 9 Apr 2017 19:18:22 -0300 Subject: Core/Misc: fix static analysis issues CID 1373466 CID 1373481 CID 1373482 --- src/server/game/Entities/Unit/Unit.cpp | 2 +- src/server/game/Handlers/CharacterHandler.cpp | 4 ++-- src/server/scripts/EasternKingdoms/Gnomeregan/gnomeregan.cpp | 8 +------- 3 files changed, 4 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/server/game/Entities/Unit/Unit.cpp b/src/server/game/Entities/Unit/Unit.cpp index 87d7bd7e9c2..4d07634a97a 100644 --- a/src/server/game/Entities/Unit/Unit.cpp +++ b/src/server/game/Entities/Unit/Unit.cpp @@ -1712,7 +1712,7 @@ uint32 Unit::CalcSpellResistedDamage(Unit* victim, uint32 damage, SpellSchoolMas while (r >= probabilitySum && resistance < 10) probabilitySum += discreteResistProbability[++resistance]; - float damageResisted = float(damage * resistance / 10); + float damageResisted = damage * resistance / 10.f; if (damageResisted > 0.0f) // if any damage was resisted { int32 ignoredResistance = 0; diff --git a/src/server/game/Handlers/CharacterHandler.cpp b/src/server/game/Handlers/CharacterHandler.cpp index db482b05b5d..bd71f39a447 100644 --- a/src/server/game/Handlers/CharacterHandler.cpp +++ b/src/server/game/Handlers/CharacterHandler.cpp @@ -1988,8 +1988,8 @@ void WorldSession::HandleCharFactionOrRaceChangeCallback(std::shared_ptrfirst; uint32 title_horde = it->second; - CharTitlesEntry const* atitleInfo = sCharTitlesStore.LookupEntry(title_alliance); - CharTitlesEntry const* htitleInfo = sCharTitlesStore.LookupEntry(title_horde); + CharTitlesEntry const* atitleInfo = sCharTitlesStore.AssertEntry(title_alliance); + CharTitlesEntry const* htitleInfo = sCharTitlesStore.AssertEntry(title_horde); // new team if (newTeam == ALLIANCE) { diff --git a/src/server/scripts/EasternKingdoms/Gnomeregan/gnomeregan.cpp b/src/server/scripts/EasternKingdoms/Gnomeregan/gnomeregan.cpp index eb65bf1dfb3..6a200a8089b 100644 --- a/src/server/scripts/EasternKingdoms/Gnomeregan/gnomeregan.cpp +++ b/src/server/scripts/EasternKingdoms/Gnomeregan/gnomeregan.cpp @@ -553,12 +553,6 @@ class spell_collecting_fallout : public SpellScriptLoader { PrepareSpellScript(spell_collecting_fallout_SpellScript); - bool Load() override - { - _spellFail = true; - return true; - } - void OnLaunch(SpellEffIndex effIndex) { // estimated 25% chance of success @@ -580,7 +574,7 @@ class spell_collecting_fallout : public SpellScriptLoader OnEffectLaunch += SpellEffectFn(spell_collecting_fallout_SpellScript::HandleFail, EFFECT_1, SPELL_EFFECT_TRIGGER_SPELL); } - bool _spellFail; + bool _spellFail = true; }; SpellScript* GetSpellScript() const override -- cgit v1.2.3