From e96676aeddb4763f6353675724fd6a033d60fbcb Mon Sep 17 00:00:00 2001 From: Naios Date: Wed, 18 Mar 2015 20:23:47 +0100 Subject: Core/Misc: Fix some issues detected by static analysis * Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? -> This argument is passed by value, it makes no sence so set it to null here. * Member variable 'instance_violet_hold_InstanceMapScript::bWiped' is not initialized in the constructor. (cherry picked from commit 433bc289c2c82b7377ad0189e415a3ca070d220f) --- src/server/game/AuctionHouse/AuctionHouseMgr.cpp | 2 -- src/server/scripts/Northrend/VioletHold/instance_violet_hold.cpp | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) (limited to 'src') diff --git a/src/server/game/AuctionHouse/AuctionHouseMgr.cpp b/src/server/game/AuctionHouse/AuctionHouseMgr.cpp index e8c91479cc2..0235aa7e8b6 100644 --- a/src/server/game/AuctionHouse/AuctionHouseMgr.cpp +++ b/src/server/game/AuctionHouse/AuctionHouseMgr.cpp @@ -440,8 +440,6 @@ bool AuctionHouseObject::RemoveAuction(AuctionEntry* auction) // we need to delete the entry, it is not referenced any more delete auction; - auction = NULL; - return wasInMap; } diff --git a/src/server/scripts/Northrend/VioletHold/instance_violet_hold.cpp b/src/server/scripts/Northrend/VioletHold/instance_violet_hold.cpp index 3e3ce5cde75..a462c68e084 100644 --- a/src/server/scripts/Northrend/VioletHold/instance_violet_hold.cpp +++ b/src/server/scripts/Northrend/VioletHold/instance_violet_hold.cpp @@ -133,6 +133,7 @@ public: uiCyanigosaEventTimer = 3 * IN_MILLISECONDS; bActive = false; + bWiped = false; bIsDoorSpellCast = false; bCrystalActivated = false; defenseless = true; -- cgit v1.2.3