From ee3d3ab1ff5589036c41c236e4fc376f11854467 Mon Sep 17 00:00:00 2001 From: jackpoz Date: Sun, 25 Aug 2013 14:04:17 +0100 Subject: Core/Player: Fix uninitialized Player field. m_MonthlyQuestChanged was initialized only when loading a Player from DB and left uninitialized when creating a new Player. Valgrind log: Conditional jump or move depends on uninitialised value(s) at 0x1148E2A: Player::_SaveMonthlyQuestStatus(Trinity::AutoPtr&) (Player.cpp:19694) by 0x1146510: Player::SaveToDB(bool) (Player.cpp:19191) by 0x14F5D5C: WorldSession::HandleCharCreateCallback(Trinity::AutoPtr, CharacterCreateInfo*) (CharacterHandler.cpp:660) Closes #10620 Signed-off-by: Nay --- src/server/game/Entities/Player/Player.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src') diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp index 8f3379ee254..d570ecb1117 100644 --- a/src/server/game/Entities/Player/Player.cpp +++ b/src/server/game/Entities/Player/Player.cpp @@ -864,6 +864,8 @@ Player::Player(WorldSession* session): Unit(true) m_WeeklyQuestChanged = false; + m_MonthlyQuestChanged = false; + m_SeasonalQuestChanged = false; SetPendingBind(0, 0); -- cgit v1.2.3