From f0bd90cc35098475b20e736cf98885c99c04be3d Mon Sep 17 00:00:00 2001 From: jackpoz Date: Wed, 29 May 2019 21:12:50 +0200 Subject: Core/Channel: Fix CRT Debug Assert triggered with invalid channel names --- src/server/game/Handlers/ChannelHandler.cpp | 2 +- src/server/scripts/Commands/cs_modify.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/server/game/Handlers/ChannelHandler.cpp b/src/server/game/Handlers/ChannelHandler.cpp index d78db9d8bb7..be163d343cc 100644 --- a/src/server/game/Handlers/ChannelHandler.cpp +++ b/src/server/game/Handlers/ChannelHandler.cpp @@ -49,7 +49,7 @@ void WorldSession::HandleJoinChannel(WorldPacket& recvPacket) return; } - if (channelName.empty() || isdigit(channelName[0])) + if (channelName.empty() || isdigit((unsigned char)channelName[0])) { WorldPacket data(SMSG_CHANNEL_NOTIFY, 1 + channelName.size()); data << uint8(CHAT_INVALID_NAME_NOTICE) << channelName; diff --git a/src/server/scripts/Commands/cs_modify.cpp b/src/server/scripts/Commands/cs_modify.cpp index 1c52b386901..8a669557f83 100644 --- a/src/server/scripts/Commands/cs_modify.cpp +++ b/src/server/scripts/Commands/cs_modify.cpp @@ -728,7 +728,7 @@ public: return false; amount = atoi(rankTxt); - if ((amount == 0) && (rankTxt[0] != '-') && !isdigit(rankTxt[0])) + if ((amount == 0) && (rankTxt[0] != '-') && !isdigit((unsigned char)rankTxt[0])) { std::string rankStr = rankTxt; std::wstring wrankStr; -- cgit v1.2.3