From f880f2e778f5db6ecebf3321d48404c89f5b277f Mon Sep 17 00:00:00 2001 From: Shauren Date: Wed, 15 Jul 2015 16:51:12 +0200 Subject: Core/Threading: Clarified comment on ProducerConsumerQueue::WaitAndPop (cherry picked from commit 08316552b5b176e8209d7e8f15c53053d049743d) --- src/server/shared/Threading/ProducerConsumerQueue.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/server/shared/Threading/ProducerConsumerQueue.h b/src/server/shared/Threading/ProducerConsumerQueue.h index e2f13e5c339..96546960393 100644 --- a/src/server/shared/Threading/ProducerConsumerQueue.h +++ b/src/server/shared/Threading/ProducerConsumerQueue.h @@ -70,7 +70,8 @@ public: { std::unique_lock lock(_queueLock); - // we could be using .wait(lock, predicate) overload here but some threading error analysis tools produce false positives + // we could be using .wait(lock, predicate) overload here but it is broken + // https://connect.microsoft.com/VisualStudio/feedback/details/1098841 while (_queue.empty() && !_shutdown) _condition.wait(lock); -- cgit v1.2.3