From fb7a60d49d1b545e09274e396e3f740359295c23 Mon Sep 17 00:00:00 2001 From: Ovah Date: Sun, 29 Mar 2020 21:23:53 +0200 Subject: Core/Spells: fixed a possible client crash when casting pull towards dest spells with misc value 0 (#24365) * This case is not happening in 335 yet as it barely has any spell with pull towardst dest effects. However, this is very well present in 4.x and beyond so let's add it for future cherrypicks (cherry picked from commit 61aec37b4ffd5fbd0bdde4de1cf7313d578651a7) --- src/server/game/Spells/SpellEffects.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/server/game/Spells/SpellEffects.cpp b/src/server/game/Spells/SpellEffects.cpp index 2785194768d..82f615d07b4 100644 --- a/src/server/game/Spells/SpellEffects.cpp +++ b/src/server/game/Spells/SpellEffects.cpp @@ -4036,7 +4036,7 @@ void Spell::EffectPullTowardsDest() float distXY = unitTarget->GetExactDist(pos); float distZ = pos->GetPositionZ() - unitTarget->GetPositionZ(); - float speedXY = effectInfo->MiscValue / 10.0f; + float speedXY = effectInfo->MiscValue ? effectInfo->MiscValue / 10.0f : 30.0f; float speedZ = (2 * speedXY * speedXY * distZ + Movement::gravity * distXY * distXY) / (2 * speedXY * distXY); unitTarget->JumpTo(speedXY, speedZ, true, *pos); -- cgit v1.2.3