diff options
Diffstat (limited to 'pull_request_template.md')
| -rw-r--r-- | pull_request_template.md | 63 |
1 files changed, 35 insertions, 28 deletions
diff --git a/pull_request_template.md b/pull_request_template.md index 3995224c3f..47097cf778 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -1,55 +1,62 @@ -<!-- First of all, thank you for your contribution. If you intend to contribute more than once, you should really join us on our discord channel! (link is on site, in the readme etc) We can set cosmetic ranks for contributors like you! --> +<!-- First of all, THANK YOU for your contribution. +<!-- ---------------------------------------------- --> +<!-- Please fill this template unless your PR is very simple/straightforward. +<!-- Do not forget to have a look at our Pull Request tutorial: +<!-- https://github.com/azerothcore/azerothcore-wotlk/wiki/Contribute#how-to-create-a-pull-request +<!-- ---------------------------------------------- --> +<!-- If you intend to contribute more than once, you should really join us on our discord channel! +<!-- The link is on our site http://azerothcore.org/ or in the readme https://github.com/azerothcore/azerothcore-wotlk etc... +<!-- We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! --> -**Changes proposed:** -- -- +<!-- WRITE A RELEVANT TITLE --> -**Target branch(es):** +**Changes proposed:** -1.x/2.x etc. +- +- **Issues addressed:** -<!-- Just paste the link to the issue you close --> -Closes # +<!-- Just paste the link to the issue you close, like this: +<!-- Closes https://github.com/azerothcore/azerothcore-wotlk/issues/967 --> +Closes **Tests performed:** -<!-- Does it build without errors? -Did you test in-game? -What did you test? -Did you do all these tests on Linux, Mac or Windows? -etc)--> +<!-- Does it build without errors? +<!-- Did you test in-game? +<!-- What did you test? +<!-- Did you do all these tests on Linux, Mac or Windows? +<!-- Other tests performed --> **How to test the changes:** -<!-- -Describe how to test the issue before and after the pull request. -Which commands to use? Which NPC to teleport to? -Do we need to have debug flags on Cmake? -Do we need to look at the console? etc... -Try to make the work easy for testers, please --> +<!-- Describe how to test the fix after applying the Pull Request. If needed describe how to test the issue before applying the <!-- Pull Request (for example, if the issue has not been reported before). +<!-- - Which commands to use? Which NPC to teleport to? +<!-- - Do we need to have debug flags on Cmake? +<!-- - Do we need to look at the console? etc... +<!-- - We need to confirm the changes first, so try to make the work easy for testers, please. --> **Known issues and TODO list:** -<!-- This is a list with checkboxes --> -- [ ] +<!-- This is a TODO list with checkboxes to tick --> +- [ ] - [ ] +<!-- OPTIONAL - If your Pull Request is not targeting the Master branch then remove the comments and specify the Target Branch +<!-- **Target branch(es):** +---- 1.x/2.x etc. --> + -<!-- -/!\ -/!\ -**NOTE** You no longer need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit). -/!\ -/!\ ---> +<!-- NOTE: +<!-- ----- +<!-- You no longer need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy to read history). --> |