From bc82f36f1ff46bb21d32e1cfdaec8271dde08af1 Mon Sep 17 00:00:00 2001 From: Kitzunu <24550914+Kitzunu@users.noreply.github.com> Date: Fri, 15 Oct 2021 10:25:29 +0200 Subject: refactor(Core/Unit): clean MonsterText methods (#6957) --- .../pendings/changes_1626351320866318500.md | 53 ++++++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 doc/changelog/pendings/changes_1626351320866318500.md (limited to 'doc') diff --git a/doc/changelog/pendings/changes_1626351320866318500.md b/doc/changelog/pendings/changes_1626351320866318500.md new file mode 100644 index 0000000000..667fac3dd3 --- /dev/null +++ b/doc/changelog/pendings/changes_1626351320866318500.md @@ -0,0 +1,53 @@ +### Added + +```cpp +// Unit.cpp + virtual void Talk(std::string_view text, ChatMsg msgType, Language language, float textRange, WorldObject const* target); + virtual void Say(std::string_view text, Language language, WorldObject const* target = nullptr); + virtual void Yell(std::string_view text, Language language, WorldObject const* target = nullptr); + virtual void TextEmote(std::string_view text, WorldObject const* target = nullptr, bool isBossEmote = false); + virtual void Whisper(std::string_view text, Language language, Player* target, bool isBossWhisper = false); + virtual void Talk(uint32 textId, ChatMsg msgType, float textRange, WorldObject const* target); + virtual void Say(uint32 textId, WorldObject const* target = nullptr); + virtual void Yell(uint32 textId, WorldObject const* target = nullptr); + virtual void TextEmote(uint32 textId, WorldObject const* target = nullptr, bool isBossEmote = false); + virtual void Whisper(uint32 textId, Player* target, bool isBossWhisper = false); +``` + +### Removed + +```cpp +// Object.cpp + void MonsterSay(const char* text, uint32 language, WorldObject const* target); + void MonsterYell(const char* text, uint32 language, WorldObject const* target); + void MonsterTextEmote(const char* text, WorldObject const* target, bool IsBossEmote = false); + void MonsterWhisper(const char* text, Player const* target, bool IsBossWhisper = false); + void MonsterSay(int32 textId, uint32 language, WorldObject const* target); + void MonsterYell(int32 textId, uint32 language, WorldObject const* target); + void MonsterTextEmote(int32 textId, WorldObject const* target, bool IsBossEmote = false); + void MonsterWhisper(int32 textId, Player const* target, bool IsBossWhisper = false); + + void SendPlaySound(uint32 Sound, bool OnlySelf); +``` + +### How to upgrade + +```diff +- creature->MonsterSay(text, LANG_XXX, nullptr); ++ creature->Say(text, LANG_XXX); + +- creature->MonsterTextEmote(text, 0); ++ creature->TextEmote(text); + +- creature->MonsterWhisper(text, receiver); ++ creature->Whisper(text, LANG_XXX, receiver); + +- creature->MonsterYell(text, LANG_XXX, NULL); ++ creature->Yell(text, LANG_XXX); + +- creature->MonsterWhisper(text, target, isBossWhisper); ++ creature->Whisper(text, LANG_XXX, target, isBossWhisper); + +- SendPlaySound(uint32 Sound, bool OnlySelf); + PlayDirectSound(uint32 sound_id, Player* target = nullptr); +``` -- cgit v1.2.3