Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-15 23:20:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/Players: Drop Player::SaveGoldToDB() and move it's code to Player::SaveInventoryAndGoldToDB() (#29582)

Browse Source
This commit is contained in:
Mykhailo Redko
2024-02-25 19:58:00 +02:00
committed by GitHub
parent 31236de396
commit 02b977c98e
5 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/server/game/AuctionHouse/AuctionHouseMgr.cpp
View File

@@ -1684,7 +1684,7 @@ bool AuctionHouseObject::BuyCommodity(CharacterDatabaseTransaction trans, Player
}
player->ModifyMoney(-int64(totalPrice));
player->SaveGoldToDB(trans);
player->SaveInventoryAndGoldToDB(trans);
for (MailedItemsBatch const& batch : items)
{

4
src/server/game/Entities/Player/Player.cpp
View File

@@ -20381,11 +20381,7 @@ void Player::SaveInventoryAndGoldToDB(CharacterDatabaseTransaction trans)
{
_SaveInventory(trans);
_SaveCurrency(trans);
SaveGoldToDB(trans);
}
void Player::SaveGoldToDB(CharacterDatabaseTransaction trans) const
{
CharacterDatabasePreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_UPD_CHAR_MONEY);
stmt->setUInt64(0, GetMoney());
stmt->setUInt64(1, GetGUID().GetCounter());

1
src/server/game/Entities/Player/Player.h
View File

@@ -1716,7 +1716,6 @@ class TC_GAME_API Player final : public Unit, public GridObject<Player>
void SaveToDB(bool create = false);
void SaveToDB(LoginDatabaseTransaction loginTransaction, CharacterDatabaseTransaction trans, bool create = false);
void SaveInventoryAndGoldToDB(CharacterDatabaseTransaction trans); // fast save function for item/money cheating preventing
void SaveGoldToDB(CharacterDatabaseTransaction trans) const;
static void SaveCustomizations(CharacterDatabaseTransaction trans, ObjectGuid::LowType guid,
Trinity::IteratorPair<UF::ChrCustomizationChoice const*> customizations);

4
src/server/game/Guilds/Guild.cpp
View File

@@ -2062,7 +2062,7 @@ void Guild::HandleMemberDepositMoney(WorldSession* session, uint64 amount, bool
if (!cashFlow)
{
player->ModifyMoney(-int64(amount));
player->SaveGoldToDB(trans);
player->SaveInventoryAndGoldToDB(trans);
}
_LogBankEvent(trans, cashFlow ? GUILD_BANK_LOG_CASH_FLOW_DEPOSIT : GUILD_BANK_LOG_DEPOSIT_MONEY, uint8(0), player->GetGUID().GetCounter(), amount);
@@ -2108,7 +2108,7 @@ bool Guild::HandleMemberWithdrawMoney(WorldSession* session, uint64 amount, bool
if (!player->ModifyMoney(amount))
return false;
player->SaveGoldToDB(trans);
player->SaveInventoryAndGoldToDB(trans);
}
// Update remaining money amount

2
src/server/game/Handlers/MailHandler.cpp
View File

@@ -547,7 +547,7 @@ void WorldSession::HandleMailTakeMoney(WorldPackets::Mail::MailTakeMoney& takeMo
// save money and mail to prevent cheating
CharacterDatabaseTransaction trans = CharacterDatabase.BeginTransaction();
player->SaveGoldToDB(trans);
player->SaveInventoryAndGoldToDB(trans);
player->_SaveMail(trans);
CharacterDatabase.CommitTransaction(trans);
}