Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-20 09:17:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

*Consider all non-existing spells as negative. This fixes the broken Forbearance.

Browse Source 
--HG--
branch : trunk
This commit is contained in:
megamage
2009-08-11 11:32:32 -05:00
parent d4165ac36e
commit 08d4aac161
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/game/SpellMgr.cpp
View File

@@ -954,17 +954,23 @@ bool SpellMgr::_isPositiveEffect(uint32 spellId, uint32 effIndex, bool deep) con
bool IsPositiveSpell(uint32 spellId)
{
return !(spellmgr.GetSpellCustomAttr(spellId) & SPELL_ATTR_CU_NEGATIVE);
uint32 attr = spellmgr.GetSpellCustomAttr(spellId); // non-existing spells such as 61988 (Forbearance)
if(!attr)
return false;
return !(attr & SPELL_ATTR_CU_NEGATIVE);
}
bool IsPositiveEffect(uint32 spellId, uint32 effIndex)
{
uint32 attr = spellmgr.GetSpellCustomAttr(spellId);
if(!attr)
return false;
switch(effIndex)
{
default:
case 0: return !(spellmgr.GetSpellCustomAttr(spellId) & SPELL_ATTR_CU_NEGATIVE_EFF0);
case 1: return !(spellmgr.GetSpellCustomAttr(spellId) & SPELL_ATTR_CU_NEGATIVE_EFF1);
case 2: return !(spellmgr.GetSpellCustomAttr(spellId) & SPELL_ATTR_CU_NEGATIVE_EFF2);
case 0: return !(attr & SPELL_ATTR_CU_NEGATIVE_EFF0);
case 1: return !(attr & SPELL_ATTR_CU_NEGATIVE_EFF1);
case 2: return !(attr & SPELL_ATTR_CU_NEGATIVE_EFF2);
}
}