Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-21 09:44:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/Misc: Fixed a bunch of uninitialized class fields

Browse Source
This commit is contained in:
Shauren
2023-12-31 17:08:54 +01:00
parent a5d2d6e465
commit 099ad4a0fd
7 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/server/game/AI/CreatureAIImpl.h
View File

@@ -75,7 +75,7 @@ enum SelectEffect : uint8
struct AISpellInfoType
{
AISpellInfoType() : target(AITARGET_SELF), condition(AICOND_COMBAT)
, cooldown(AI_DEFAULT_COOLDOWN), realCooldown(0), maxRange(0.0f){ }
, cooldown(AI_DEFAULT_COOLDOWN), realCooldown(0), maxRange(0.0f), Targets(0), Effects(0) { }
AITarget target;
AICondition condition;
Milliseconds cooldown;

2
src/server/game/AuctionHouseBot/AuctionHouseBot.h
View File

@@ -209,7 +209,7 @@ enum AuctionBotConfigFloatValues
class TC_GAME_API AuctionBotConfig
{
private:
AuctionBotConfig(): _itemsPerCycleBoost(1000), _itemsPerCycleNormal(20) {}
AuctionBotConfig(): _itemsPerCycleBoost(1000), _itemsPerCycleNormal(20), _configUint32Values(), _configBoolValues(), _configFloatValues() { }
~AuctionBotConfig() {}
AuctionBotConfig(AuctionBotConfig const&) = delete;
AuctionBotConfig& operator=(AuctionBotConfig const&) = delete;

2
src/server/game/Entities/GameObject/GameObject.cpp
View File

@@ -96,7 +96,7 @@ WorldPacket GameObjectTemplate::BuildQueryData(LocaleConstant loc) const
for (int32 item : *items)
stats.QuestItems.push_back(item);
memcpy(stats.Data, raw.data, MAX_GAMEOBJECT_DATA * sizeof(int32));
memcpy(stats.Data.data(), raw.data, MAX_GAMEOBJECT_DATA * sizeof(int32));
stats.ContentTuningId = ContentTuningId;
queryTemp.Write();

3
src/server/game/Guilds/Guild.cpp
View File

@@ -520,6 +520,7 @@ Guild::Member::Member(ObjectGuid::LowType guildId, ObjectGuid guid, GuildRankId
m_logoutTime(GameTime::GetGameTime()),
m_accountId(0),
m_rankId(rankId),
m_bankWithdraw(),
m_bankWithdrawMoney(0),
m_achievementPoints(0),
m_totalActivity(0),
@@ -1430,8 +1431,8 @@ void Guild::HandleSetAchievementTracking(WorldSession* session, uint32 const* ac
}
}
GetAchievementMgr().SendAllTrackedCriterias(player, criteriaIds);
member->SetTrackedCriteriaIds(std::move(criteriaIds));
GetAchievementMgr().SendAllTrackedCriterias(player, member->GetTrackedCriteriaIds());
}
}

9
src/server/game/Guilds/Guild.h
View File

@@ -352,9 +352,8 @@ class TC_GAME_API Guild
uint32 GetTotalReputation() const { return m_totalReputation; }
uint32 GetWeekReputation() const { return m_weekReputation; }
std::set<uint32> const& GetTrackedCriteriaIds() const { return m_trackedCriteriaIds; }
void SetTrackedCriteriaIds(std::set<uint32> criteriaIds) { m_trackedCriteriaIds = std::move(criteriaIds); }
bool IsTrackingCriteriaId(uint32 criteriaId) const { return m_trackedCriteriaIds.find(criteriaId) != m_trackedCriteriaIds.end(); }
bool IsTrackingCriteriaId(uint32 criteriaId) const { return m_trackedCriteriaIds && m_trackedCriteriaIds->contains(criteriaId); }
bool IsOnline() const { return (m_flags & GUILDMEMBER_STATUS_ONLINE); }
@@ -366,8 +365,8 @@ class TC_GAME_API Guild
void UpdateBankTabWithdrawValue(CharacterDatabaseTransaction trans, uint8 tabId, uint32 amount);
void UpdateBankMoneyWithdrawValue(CharacterDatabaseTransaction trans, uint64 amount);
uint32 GetBankTabWithdrawValue(uint8 tabId) const { return m_bankWithdraw[tabId]; };
uint64 GetBankMoneyWithdrawValue() const { return m_bankWithdrawMoney; };
uint32 GetBankTabWithdrawValue(uint8 tabId) const { return m_bankWithdraw[tabId]; }
uint64 GetBankMoneyWithdrawValue() const { return m_bankWithdrawMoney; }
void ResetValues(bool weekly = false);
Player* FindPlayer() const;
@@ -391,7 +390,7 @@ class TC_GAME_API Guild
std::string m_publicNote;
std::string m_officerNote;
std::set<uint32> m_trackedCriteriaIds;
Optional<std::set<uint32>> m_trackedCriteriaIds;
std::array<uint32, GUILD_BANK_MAX_TABS> m_bankWithdraw;
uint64 m_bankWithdrawMoney;

8
src/server/game/Server/Packets/QueryPackets.h
View File

@@ -210,8 +210,8 @@ namespace WorldPackets
uint32 TextID = 0;
bool Allow = false;
std::array<float, MAX_NPC_TEXT_OPTIONS> Probabilities;
std::array<uint32, MAX_NPC_TEXT_OPTIONS> BroadcastTextID;
std::array<float, MAX_NPC_TEXT_OPTIONS> Probabilities = { };
std::array<uint32, MAX_NPC_TEXT_OPTIONS> BroadcastTextID = { };
};
class QueryGameObject final : public ClientPacket
@@ -233,7 +233,7 @@ namespace WorldPackets
std::string UnkString;
uint32 Type = 0;
uint32 DisplayID = 0;
uint32 Data[MAX_GAMEOBJECT_DATA];
std::array<uint32, MAX_GAMEOBJECT_DATA> Data = { };
float Size = 0.0f;
std::vector<int32> QuestItems;
uint32 ContentTuningId = 0;
@@ -326,7 +326,7 @@ namespace WorldPackets
void Read() override;
int32 MissingQuestCount = 0;
std::array<int32, 175> MissingQuestPOIs;
std::array<int32, 175> MissingQuestPOIs = { };
};
class QuestPOIQueryResponse final : public ServerPacket

2
src/server/game/Server/Packets/SpellPackets.h
View File

@@ -368,7 +368,7 @@ namespace WorldPackets
std::vector<SpellPowerData> RemainingPower;
Optional<RuneData> RemainingRunes;
MissileTrajectoryResult MissileTrajectory;
int32 AmmoDisplayID;
int32 AmmoDisplayID = 0;
uint8 DestLocSpellCastIndex = 0;
std::vector<TargetLocation> TargetPoints;
CreatureImmunities Immunities;