Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-15 23:20:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

CI/GitHub: Update basic guideline in issue form for SQL fixes

Browse Source
This commit is contained in:
offl
2021-07-05 16:45:29 +03:00
committed by GitHub
parent 6b8bb270a8
commit 3aaab1f878
1 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
.github/ISSUE_TEMPLATE/sql_fix.yml vendored
View File

@@ -7,17 +7,18 @@ body:
value: |
Thanks for taking the time to fill out this form! Please make sure to fill all fields, including the Title above.
For SQL fixes:
- search for existing issues, if a bug report exist for the issue you are trying to fix and it's opened post there.
- don't modify WDB fields without supply one sniff of those fields (censure guids, character names, anything blizzard can use to identify source)
- don't use pull requests for sql only fixes, unless it's to fix one existing unable to apply file.
- don't hardcode guids.
- don't DELETE + INSERT to update only few fields of one row.
- don't use database names.
- don't put ' around numbers.
- don't put ( ) if they aren't needed.
- use only 1 DELETE + INSERT when we add multiple items to one table, unless you are scripting multiple creatures.
- start fix by -- in case some previous sql misses proper ending.
- DELETE by guid AND entry to be sure we don't delete existing spawns.
- search for existing issues. If a bug report exists for the issue you are trying to fix, and it's open, post your suggestion there
- always start suggestion by -- in case previous SQL file has no newline
- don't modify WDB fields without providing sniffs of those fields (censure guids, character names, anything blizzard can use to identify source)
- don't hardcode guids (use guid from fixed guid range when adding new objects or creatures)
- don't DELETE + INSERT to update only few fields of one row
- don't use database names
- don't use ' around numbers
- don't use ( ) if they aren't needed
- use only one INSERT INTO statement when you add multiple rows to one table, unless you are scripting multiple creatures
- always include column names in every INSERT INTO statement
- always make every INSERT INTO statement runnable twice (delete what you insert even if row does not exist, don't use REPLACE INTO)
- DELETE by guid AND id to be sure we don't delete existing spawns
The wiki page https://github.com/TrinityCore/TrinityCore/wiki/SQL-Fix includes additional details about how to fill this form and an example of a SQL fix.
- type: textarea