Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-22 10:05:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/Commands: Fix heap-use-after-free in ".ticket delete" command

Browse Source 
Reported by Address Sanitizer
This commit is contained in:
jackpoz
2019-04-28 18:56:45 +02:00
parent f45ebe71b0
commit 3f0ce98f7c
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/server/scripts/Commands/cs_ticket.cpp
View File

@@ -291,9 +291,6 @@ public:
std::string msg = ticket->FormatMessageString(*handler, nullptr, nullptr, nullptr, handler->GetSession() ? handler->GetSession()->GetPlayer()->GetName().c_str() : "Console", nullptr);
handler->SendGlobalGMSysMessage(msg.c_str());
sTicketMgr->RemoveTicket(ticket->GetId());
sTicketMgr->UpdateLastChange();
if (Player* player = ticket->GetPlayer())
{
// Force abandon ticket
@@ -302,6 +299,9 @@ public:
player->SendDirectMessage(&data);
}
sTicketMgr->RemoveTicket(ticket->GetId());
sTicketMgr->UpdateLastChange();
return true;
}