mirror of
https://github.com/TrinityCore/TrinityCore.git
synced 2026-01-16 07:30:42 +01:00
Core/Misc: Fix some issues detected by static analysis
* Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? -> This argument is passed by value, it makes no sence so set it to null here. * Member variable 'instance_violet_hold_InstanceMapScript::bWiped' is not initialized in the constructor. * Mismatching allocation and deallocation: Data
This commit is contained in:
@@ -54,9 +54,10 @@ namespace Battlenet
|
||||
memcpy(Data, right.Data, DataSize);
|
||||
}
|
||||
}
|
||||
|
||||
~ModuleInfo()
|
||||
{
|
||||
delete Data;
|
||||
delete[] Data;
|
||||
}
|
||||
|
||||
std::string Type;
|
||||
|
||||
@@ -440,8 +440,6 @@ bool AuctionHouseObject::RemoveAuction(AuctionEntry* auction)
|
||||
|
||||
// we need to delete the entry, it is not referenced any more
|
||||
delete auction;
|
||||
auction = NULL;
|
||||
|
||||
return wasInMap;
|
||||
}
|
||||
|
||||
|
||||
@@ -133,6 +133,7 @@ public:
|
||||
uiCyanigosaEventTimer = 3 * IN_MILLISECONDS;
|
||||
|
||||
bActive = false;
|
||||
bWiped = false;
|
||||
bIsDoorSpellCast = false;
|
||||
bCrystalActivated = false;
|
||||
defenseless = true;
|
||||
|
||||
Reference in New Issue
Block a user