Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-22 10:05:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/LFG: validate player roles on lfg join to avoid cheating players to join with roles that they should not be able to join

Browse Source
This commit is contained in:
Ovahlord
2019-08-30 13:35:17 +02:00
parent cb79782662
commit 4737bcb866
3 changed files with 25 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/server/game/DungeonFinding/LFGMgr.cpp
View File

@@ -484,6 +484,8 @@ void LFGMgr::JoinLfg(Player* player, uint8 roles, LfgDungeonSet& dungeons, const
joinData.result = LFG_JOIN_NOT_MEET_REQS;
else if (player->HasAura(9454)) // check Freeze debuff
joinData.result = LFG_JOIN_NOT_MEET_REQS;
else if (!CanPerformSelectedRoles(player->getClass(), roles))
joinData.result = LFG_JOIN_INTERNAL_ERROR;
else if (grp)
{
if (grp->GetMembersCount() > MAXGROUPSIZE)
@@ -2282,4 +2284,18 @@ uint32 LFGMgr::GetShortageRoleMask(uint32 dungeonId)
return ShortageRoleMaskStore[dungeonId];
}
bool LFGMgr::CanPerformSelectedRoles(uint8 playerClass, uint8 roles) const
{
// Role Validation
if (roles & lfg::PLAYER_ROLE_TANK && (playerClass != CLASS_DEATH_KNIGHT && playerClass != CLASS_DRUID
&& playerClass != CLASS_PALADIN && playerClass != CLASS_WARRIOR))
return false;
if (roles & lfg::PLAYER_ROLE_HEALER && (playerClass != CLASS_PALADIN && playerClass != CLASS_DRUID
&& playerClass != CLASS_PRIEST && playerClass != CLASS_SHAMAN))
return false;
return true;
}
} // namespace lfg

4
src/server/game/DungeonFinding/LFGMgr.h
View File

@@ -454,6 +454,10 @@ class TC_GAME_API LFGMgr
/// Returns the stored role mask for the shortage system indexed by random dungeon id
uint32 GetShortageRoleMask(uint32 dungeonId);
// WPE Protection
/// Checks if the player's class is allowed to perform his selected roles
bool CanPerformSelectedRoles(uint8 playerClass, uint8 roles) const;
private:
uint8 GetTeam(ObjectGuid guid);
void RestoreState(ObjectGuid guid, char const* debugMsg);

5
src/server/game/Handlers/LFGHandler.cpp
View File

@@ -85,6 +85,11 @@ void WorldSession::HandleLfgSetRolesOpcode(WorldPackets::LFG::LFGSetRoles& lfgSe
ObjectGuid gguid = group->GetGUID();
TC_LOG_DEBUG("lfg", "CMSG_LFG_SET_ROLES: Group %s, Player %s, Roles: %u",
gguid.ToString().c_str(), GetPlayerInfo().c_str(), lfgSetRoles.RolesDesired);
// Role validation
if (!sLFGMgr->CanPerformSelectedRoles(GetPlayer()->getClass(), lfgSetRoles.RolesDesired))
lfgSetRoles.RolesDesired = 0;
sLFGMgr->UpdateRoleCheck(gguid, guid, lfgSetRoles.RolesDesired);
}