Core/CrashHandler: #ifdef cleanup to make VS not choke when parsing, fixed file being all red in editor

(cherry picked from commit 39c5e03b74)

src/CMakeLists.txt

@@ -8,12 +8,12 @@
 # WITHOUT ANY WARRANTY, to the extent permitted by law; without even the
 # implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 
-if(WIN32)
+if(WIN32 AND MSVC)
   set(sources_windows
     ${CMAKE_SOURCE_DIR}/src/common/Debugging/WheatyExceptionReport.cpp
     ${CMAKE_SOURCE_DIR}/src/common/Debugging/WheatyExceptionReport.h
   )
-endif(WIN32)
+endif()
 
 add_subdirectory(genrev)
 add_subdirectory(common)

src/common/Debugging/WheatyExceptionReport.cpp

@@ -3,30 +3,16 @@
 // MSDN Magazine, 2002
 // FILE: WheatyExceptionReport.CPP
 //==========================================
-#include "CompilerDefs.h"
-
-#if TRINITY_PLATFORM == TRINITY_PLATFORM_WINDOWS && !defined(__MINGW32__)
-#ifndef WIN32_LEAN_AND_MEAN
-#define WIN32_LEAN_AND_MEAN
-#endif
-#pragma warning(disable:4996)
-#pragma warning(disable:4312)
-#pragma warning(disable:4311)
-#include <windows.h>
-#include <tlhelp32.h>
-#include <cstdio>
-#include <tchar.h>
-#define _NO_CVCONST_H
-#include <dbghelp.h>
-
 #include "WheatyExceptionReport.h"
-
 #include "Common.h"
 #include "Errors.h"
 #include "GitRevision.h"
 #include <algorithm>
 #include <ehdata.h>
 #include <rttidata.h>
+#include <cstdio>
+#include <tlhelp32.h>
+#include <tchar.h>
 
 #define CrashFolder _T("Crashes")
 #pragma comment(linker, "/DEFAULTLIB:dbghelp.lib")
@@ -437,14 +423,14 @@ void WheatyExceptionReport::PrintSystemInfo()
     ::GlobalMemoryStatus(&MemoryStatus);
     TCHAR sString[1024];
     Log(_T("//=====================================================\r\n"));
-    if (_GetProcessorName(sString, countof(sString)))
+    if (_GetProcessorName(sString, std::size(sString)))
         Log(_T("*** Hardware ***\r\nProcessor: %s\r\nNumber Of Processors: %d\r\nPhysical Memory: %d KB (Available: %d KB)\r\nCommit Charge Limit: %d KB\r\n"),
             sString, SystemInfo.dwNumberOfProcessors, MemoryStatus.dwTotalPhys/0x400, MemoryStatus.dwAvailPhys/0x400, MemoryStatus.dwTotalPageFile/0x400);
     else
         Log(_T("*** Hardware ***\r\nProcessor: <unknown>\r\nNumber Of Processors: %d\r\nPhysical Memory: %d KB (Available: %d KB)\r\nCommit Charge Limit: %d KB\r\n"),
             SystemInfo.dwNumberOfProcessors, MemoryStatus.dwTotalPhys/0x400, MemoryStatus.dwAvailPhys/0x400, MemoryStatus.dwTotalPageFile/0x400);
 
-    if (_GetWindowsVersion(sString, countof(sString)))
+    if (_GetWindowsVersion(sString, std::size(sString)))
         Log(_T("\r\n*** Operation System ***\r\n%s\r\n"), sString);
     else
         Log(_T("\r\n*** Operation System:\r\n<unknown>\r\n"));
@@ -1588,5 +1574,3 @@ std::string SymbolDetail::ToString()
     }
     return formatted;
 }
-
-#endif  // _WIN32

src/common/Debugging/WheatyExceptionReport.h

@@ -1,16 +1,16 @@
 #ifndef _WHEATYEXCEPTIONREPORT_
 #define _WHEATYEXCEPTIONREPORT_
 
-#if TRINITY_PLATFORM == TRINITY_PLATFORM_WINDOWS && !defined(__MINGW32__)
+#define _NO_CVCONST_H
 
+#include <windows.h>
 #include <winnt.h>
 #include <winternl.h>
 #include <dbghelp.h>
 #include <set>
-#include <stdlib.h>
+#include <cstdlib>
 #include <stack>
 #include <mutex>
-#define countof  _countof
 
 #define WER_MAX_ARRAY_ELEMENTS_COUNT 10
 #define WER_MAX_NESTING_LEVEL 4
@@ -200,5 +200,4 @@ class WheatyExceptionReport
 };
 
 extern WheatyExceptionReport g_WheatyExceptionReport;       //  global instance of class
-#endif                                                      // _WIN32
 #endif                                                      // _WHEATYEXCEPTIONREPORT_

src/server/bnetserver/CMakeLists.txt

@@ -16,8 +16,9 @@ CollectSourceFiles(
   # Exclude
   ${CMAKE_CURRENT_SOURCE_DIR}/PrecompiledHeaders)
 
+list(APPEND PRIVATE_SOURCES ${sources_windows})
+
 if (WIN32)
-  list(APPEND PRIVATE_SOURCES ${sources_windows})
   if (MSVC)
     list(APPEND PRIVATE_SOURCES bnetserver.rc)
   endif()

src/server/worldserver/CMakeLists.txt

@@ -14,8 +14,9 @@ CollectSourceFiles(
   # Exclude
   ${CMAKE_CURRENT_SOURCE_DIR}/PrecompiledHeaders)
 
+list(APPEND PRIVATE_SOURCES ${sources_windows})
+
 if(WIN32)
-  list(APPEND PRIVATE_SOURCES ${sources_windows})
   if(MSVC)
     list(APPEND PRIVATE_SOURCES worldserver.rc)
   endif()

src/tools/map_extractor/CMakeLists.txt

@@ -12,9 +12,7 @@ CollectSourceFiles(
   ${CMAKE_CURRENT_SOURCE_DIR}
   PRIVATE_SOURCES)
 
-if(WIN32)
-  list(APPEND PRIVATE_SOURCES ${sources_windows})
-endif()
+list(APPEND PRIVATE_SOURCES ${sources_windows})
 
 add_executable(mapextractor
   ${PRIVATE_SOURCES}

src/tools/mmaps_generator/CMakeLists.txt

@@ -12,9 +12,7 @@ CollectSourceFiles(
   ${CMAKE_CURRENT_SOURCE_DIR}
   PRIVATE_SOURCES)
 
-if(WIN32)
-  list(APPEND PRIVATE_SOURCES ${sources_windows})
-endif()
+list(APPEND PRIVATE_SOURCES ${sources_windows})
 
 add_executable(mmaps_generator ${PRIVATE_SOURCES})
 

src/tools/vmap4_assembler/CMakeLists.txt

@@ -13,9 +13,7 @@ set(PRIVATE_SOURCES
   TileAssembler.h
   VMapAssembler.cpp)
 
-if(WIN32)
-  list(APPEND PRIVATE_SOURCES ${sources_windows})
-endif()
+list(APPEND PRIVATE_SOURCES ${sources_windows})
 
 add_executable(vmap4assembler ${PRIVATE_SOURCES})
 

src/tools/vmap4_extractor/CMakeLists.txt

@@ -12,9 +12,7 @@ CollectSourceFiles(
   ${CMAKE_CURRENT_SOURCE_DIR}
   PRIVATE_SOURCES)
 
-if(WIN32)
-  list(APPEND PRIVATE_SOURCES ${sources_windows})
-endif()
+list(APPEND PRIVATE_SOURCES ${sources_windows})
 
 add_executable(vmap4extractor ${PRIVATE_SOURCES})