Core/Objects: Eliminate unneccessary temporary objects and double map lookups when building SMSG_UPDATE_OBJECT

(cherry picked from commit 38a209276d)
This commit is contained in:
Shauren
2024-10-28 00:52:19 +01:00
committed by Ovahlord
parent 2c99afab5e
commit 56ada5b873

View File

@@ -852,15 +852,7 @@ void Object::ClearUpdateMask(bool remove)
void Object::BuildFieldsUpdate(Player* player, UpdateDataMapType& data_map) const
{
UpdateDataMapType::iterator iter = data_map.find(player);
if (iter == data_map.end())
{
std::pair<UpdateDataMapType::iterator, bool> p = data_map.emplace(player, UpdateData(player->GetMapId()));
ASSERT(p.second);
iter = p.first;
}
UpdateDataMapType::iterator iter = data_map.try_emplace(player, player->GetMapId()).first;
BuildValuesUpdateBlockForPlayer(&iter->second, iter->first);
}