Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-15 23:20:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/Misc: ASSERT() cleanup

Browse Source 
Move some functions calls out of ASSERT() calls. ASSERT() should only apply checks without modifying any object and without having any side effect.
This commit is contained in:
jackpoz
2018-02-17 23:26:50 +01:00
parent 76b57eeba8
commit 572eab1c35
4 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/server/game/DataStores/DBCStores.cpp
View File

@@ -439,7 +439,8 @@ void LoadDBCStores(const std::string& dataPath)
{
ASSERT(namesProfanity->Language < TOTAL_LOCALES || namesProfanity->Language == -1);
std::wstring wname;
ASSERT(Utf8toWStr(namesProfanity->Name, wname));
bool conversionResult = Utf8toWStr(namesProfanity->Name, wname);
ASSERT(conversionResult);
if (namesProfanity->Language != -1)
NamesProfaneValidators[namesProfanity->Language].emplace_back(wname, Trinity::regex::perl | Trinity::regex::icase | Trinity::regex::optimize);
@@ -452,7 +453,8 @@ void LoadDBCStores(const std::string& dataPath)
{
ASSERT(namesReserved->Language < TOTAL_LOCALES || namesReserved->Language == -1);
std::wstring wname;
ASSERT(Utf8toWStr(namesReserved->Name, wname));
bool conversionResult = Utf8toWStr(namesReserved->Name, wname);
ASSERT(conversionResult);
if (namesReserved->Language != -1)
NamesReservedValidators[namesReserved->Language].emplace_back(wname, Trinity::regex::perl | Trinity::regex::icase | Trinity::regex::optimize);

5
src/server/game/Entities/Vehicle/Vehicle.cpp
View File

@@ -826,7 +826,10 @@ bool VehicleJoinEvent::Execute(uint64, uint32)
if (Target->GetBase()->GetTypeId() == TYPEID_UNIT && Passenger->GetTypeId() == TYPEID_PLAYER &&
Seat->second.SeatInfo->m_flags & VEHICLE_SEAT_FLAG_CAN_CONTROL)
ASSERT(Target->GetBase()->SetCharmedBy(Passenger, CHARM_TYPE_VEHICLE)); // SMSG_CLIENT_CONTROL
{
bool charmedByResult = Target->GetBase()->SetCharmedBy(Passenger, CHARM_TYPE_VEHICLE); // SMSG_CLIENT_CONTROL
ASSERT(charmedByResult);
}
Passenger->SendClearTarget(); // SMSG_BREAK_TARGET
Passenger->SetControlled(true, UNIT_STATE_ROOT); // SMSG_FORCE_ROOT - In some cases we send SMSG_SPLINE_MOVE_ROOT here (for creatures)

3
src/server/game/Groups/Group.cpp
View File

@@ -161,7 +161,8 @@ bool Group::Create(Player* leader)
Group::ConvertLeaderInstancesToGroup(leader, this, false);
ASSERT(AddMember(leader)); // If the leader can't be added to a new group because it appears full, something is clearly wrong.
bool addMemberResult = AddMember(leader);
ASSERT(addMemberResult); // If the leader can't be added to a new group because it appears full, something is clearly wrong.
}
else if (!AddMember(leader))
return false;

9
src/server/game/Tools/PlayerDump.cpp
View File

@@ -168,10 +168,12 @@ std::vector<TableStruct> CharacterTables;
inline bool StringsEqualCaseInsensitive(std::string const& left, std::string const& right)
{
std::string upperLeftString = left;
ASSERT(Utf8ToUpperOnlyLatin(upperLeftString));
bool leftResult = Utf8ToUpperOnlyLatin(upperLeftString);
ASSERT(leftResult);
std::string upperRightString = right;
ASSERT(Utf8ToUpperOnlyLatin(upperRightString));
bool rightResult = Utf8ToUpperOnlyLatin(upperRightString);
ASSERT(rightResult);
return upperLeftString == upperRightString;
}
@@ -270,7 +272,8 @@ void PlayerDump::InitializeTables()
TableField f;
f.FieldName = columnName;
ASSERT(Utf8ToUpperOnlyLatin(columnName));
bool toUpperResult = Utf8ToUpperOnlyLatin(columnName);
ASSERT(toUpperResult);
t.TableFields.emplace_back(std::move(f));
} while (result->NextRow());