Core/Movement: moved the cleanup of the idle motion slot to CleanupBeforeRemoveFromMap

This commit is contained in:
Ovahlord
2020-06-29 12:15:17 +02:00
parent b4c4f82dd8
commit 696ab70f7f

View File

@@ -10449,8 +10449,6 @@ void Unit::RemoveFromWorld()
RemoveAreaAurasDueToLeaveWorld();
GetMotionMaster()->Clear(MOTION_SLOT_IDLE); // clear idle movement slot to finalize follow movement to unregister formation targets
if (GetCharmerGUID())
{
TC_LOG_FATAL("entities.unit", "Unit %u has charmer guid when removed from world", GetEntry());
@@ -10476,6 +10474,9 @@ void Unit::CleanupBeforeRemoveFromMap(bool finalCleanup)
// This needs to be before RemoveFromWorld to make GetCaster() return a valid pointer on aura removal
InterruptNonMeleeSpells(true);
// clear idle movement slot to finalize follow movement to unregister formation targets
GetMotionMaster()->Clear(MOTION_SLOT_IDLE);
if (IsInWorld())
RemoveFromWorld();