Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-16 07:30:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

pull_request_template.md improvements (#18158)

Browse Source 
* pull_request_template.md improvements

- hide bottom comments from saved view on github.com
- add 1 empty comment line for some sections (suggest where to write)
- add tick boxes for the branch names
- "TODO" -> ToDo (from the 2 words "to do")

* Update pull_request_template.md
This commit is contained in:
tkrokli
2016-10-28 15:49:00 +02:00
committed by Duarte Duarte
parent 08d7f094a9
commit 76910541cf
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
pull_request_template.md
View File

@@ -1,6 +1,6 @@
[//]: # (*********************************)
[//]: # (** DO NOT DELETE THIS TEMPLATE **)
[//]: # (*********************************)
[//]: # (***************************)
[//]: # (** FILL IN THIS TEMPLATE **)
[//]: # (***************************)
**Changes proposed:**
@@ -10,17 +10,21 @@
**Target branch(es):** 3.3.5/master
**Issues addressed:** Closes #
- [ ] 3.3.5
- [ ] master
**Issues addressed:** Closes # (insert issue tracker number)
**Tests performed:** (Does it build, tested in-game, etc.)
**Known issues and TODO list:**
**Known issues and TODO list:** (add/remove lines as needed)
- [ ]
- [ ]
**DEPRECATION NOTICE** When creating new PRs to the (old) 6.x branch, make sure the target branch is **master** instead of 6.x.
**NOTE** Enable the setting "Allow edits from maintainers." when creating your pull request.
**NOTE** If this PR __only__ contains SQL files, create an issue instead.
**NOTE** Squashing commits is not required.
**SUGGESTION** When adding new SQL files, name them 9999_99_99_99_db_name.sql to reduce the chance of possible merge conflicts.
[//]: # (**DEPRECATION NOTICE** Instead of creating new PRs to the (old) 6.x branch, make sure the target branch is **master** instead of 6.x.)
[//]: # (**NOTE** Enable the setting "[√] Allow edits from maintainers." when creating your pull request (if not enabled already).)
[//]: # (**NOTE** If this PR __only__ contains SQL files, open a new issue instead and post or link the SQL there.)
[//]: # (**SUGGESTION** When adding new SQL files, name them 9999_99_99_99_db_name.sql to reduce the chance of possible merge conflicts.)