Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-19 08:55:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/Player: no longer use the sOctClassCombatRatingScalar game table to calculate rating bonus multipliers to match current live server's values

Browse Source 
* this is a 'blizzlike' bug that is causing mastery rating from items to be 25% stronger than it should be
This commit is contained in:
Ovahlord
2024-08-19 04:31:55 +02:00
parent bd366706b7
commit 7ed0d6f228
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/server/game/Entities/Player/Player.cpp
View File

@@ -4889,20 +4889,20 @@ inline float GetGameTableColumnForCombatRating(GtCombatRatingsEntry const* row,
float Player::GetRatingMultiplier(CombatRating cr) const
{
float combatRatingRatio = GetGameTableColumnForCombatRating(sCombatRatingsGameTable.GetRow(GetLevel()), cr);
if (combatRatingRatio == 0.0f)
return 1.0f; // By default use minimum coefficient (not must be called)
GtCombatRatingsEntry const* Rating = sCombatRatingsGameTable.GetRow(GetLevel());
if (!Rating)
return 1.0f;
float classRatingRatio = GetGameTableColumnForClass(sOctClassCombatRatingScalarGameTable.GetRow(cr), GetClass());
if (classRatingRatio == 0.0f)
return 1.0f; // By default use minimum coefficient (not must be called)
float value = GetGameTableColumnForCombatRating(Rating, cr);
if (!value)
return 1.0f; // By default use minimum coefficient (not must be called)
return classRatingRatio / combatRatingRatio;
return 1.0f / value;
}
float Player::GetRatingBonusValue(CombatRating cr) const
{
float baseResult = float(m_activePlayerData->CombatRatings[cr]) * GetRatingMultiplier(cr);
float baseResult = (float)m_activePlayerData->CombatRatings[cr] * GetRatingMultiplier(cr);
if (cr != CR_RESILIENCE_PLAYER_DAMAGE)
return baseResult;
return float(1.0f - pow(0.99f, baseResult)) * 100.0f;