Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-19 17:05:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Common/Containers: Eliminate a edge case that could potentially lead to object invalidation.

Browse Source 
(cherry picked from commit 64a61e03ab)
This commit is contained in:
Treeston
2018-07-19 11:59:36 +02:00
committed by Shauren
parent b638f37788
commit 839d30e93b
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/common/Utilities/Containers.h
View File

@@ -68,7 +68,8 @@ namespace Trinity
// this element has chance (elementsToKeep / elementsToProcess) of being kept
if (urand(1, elementsToProcess) <= elementsToKeep)
{
*keepIt = std::move(*curIt);
if (keepIt != curIt)
*keepIt = std::move(*curIt);
++keepIt;
--elementsToKeep;
}