Core: Fix warnings

src/server/scripts/EasternKingdoms/MagistersTerrace/boss_selin_fireheart.cpp

@@ -113,7 +113,7 @@ public:
                 for (std::list<uint64>::const_iterator itr = Crystals.begin(); itr != Crystals.end(); ++itr)
                 {
                     //Unit* unit = Unit::GetUnit(*me, FelCrystals[i]);
-                    if (Creature *creature = Unit::GetCreature(*me, *itr))
+                    if (Creature* creature = Unit::GetCreature(*me, *itr))
                     {
                         if (!creature->isAlive())
                             creature->Respawn();      // Let the core handle setting death state, etc.

src/server/scripts/EasternKingdoms/tirisfal_glades.cpp

@@ -37,9 +37,9 @@ EndContentData */
 ## npc_calvin_montague
 ######*/
 
-enum eCalvin
+enum Calvin
 {
-    SAY_COMPLETE        = -1000431,
+    SAY_COMPLETE        = 0,
     SPELL_DRINK         = 2639,                             // possibly not correct spell (but iconId is correct)
     QUEST_590           = 590,
     FACTION_HOSTILE     = 168
@@ -113,15 +113,15 @@ public:
             }
         }
 
-        void UpdateAI(const uint32 uiDiff)
+        void UpdateAI(uint32 const diff)
         {
             if (m_uiPhase)
             {
-                if (m_uiPhaseTimer <= uiDiff)
+                if (m_uiPhaseTimer <= diff)
                     m_uiPhaseTimer = 7500;
                 else
                 {
-                    m_uiPhaseTimer -= uiDiff;
+                    m_uiPhaseTimer -= diff;
                     return;
                 }
 

src/server/scripts/Northrend/icecrown.cpp

@@ -860,7 +860,7 @@ public:
         }
     };
 
-    CreatureAI *GetAI(Creature *creature) const
+    CreatureAI* GetAI(Creature* creature) const
     {
         return new npc_blessed_bannerAI(creature);
     }

src/server/scripts/World/npcs_special.cpp

@@ -2951,7 +2951,7 @@ public:
                 me->GetMotionMaster()->MoveFollow(owner, PET_FOLLOW_DIST, PET_FOLLOW_ANGLE);
         }
 
-        void EnterCombat(Unit * /*who*/) { }
+        void EnterCombat(Unit* /*who*/) { }
 
         void DoAction(const int32 /*param*/)
         {