Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-02-04 16:17:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

Scripts/HoL: follow naming standards for boss enums and dropped unused overriden methods from instance script

Browse Source
This commit is contained in:
Ovahlord
2022-09-23 11:54:28 +02:00
committed by Shauren
parent 9dcb602138
commit 8b87b6a058
2 changed files with 8 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/server/scripts/Northrend/Ulduar/HallsOfLightning/halls_of_lightning.h
View File

@@ -40,10 +40,10 @@ enum HOLDataTypes
enum HOLCreaturesIds
{
// Bosses
BOSS_GENERAL_BJARNGRIM = 28586,
BOSS_VOLKHAN = 28587,
BOSS_IONAR = 28546,
BOSS_LOKEN = 28923
NPC_GENERAL_BJARNGRIM = 28586,
NPC_VOLKHAN = 28587,
NPC_IONAR = 28546,
NPC_LOKEN = 28923
};
enum HOLGameObjectIds

23
src/server/scripts/Northrend/Ulduar/HallsOfLightning/instance_halls_of_lightning.cpp
View File

@@ -32,10 +32,10 @@ DoorData const doorData[] =
ObjectData const creatureData[] =
{
{ BOSS_GENERAL_BJARNGRIM, DATA_GENERAL_BJARNGRIM },
{ BOSS_VOLKHAN, DATA_VOLKHAN },
{ BOSS_IONAR, DATA_IONAR },
{ BOSS_LOKEN, DATA_LOKEN },
{ NPC_GENERAL_BJARNGRIM, DATA_GENERAL_BJARNGRIM },
{ NPC_VOLKHAN, DATA_VOLKHAN },
{ NPC_IONAR, DATA_IONAR },
{ NPC_LOKEN, DATA_LOKEN },
{ 0, 0 } // END
};
@@ -60,16 +60,6 @@ class instance_halls_of_lightning : public InstanceMapScript
LoadDoorData(doorData);
}
void OnCreatureCreate(Creature* creature) override
{
InstanceScript::OnCreatureCreate(creature);
}
void OnGameObjectCreate(GameObject* go) override
{
InstanceScript::OnGameObjectCreate(go);
}
bool SetBossState(uint32 type, EncounterState state) override
{
if (!InstanceScript::SetBossState(type, state))
@@ -88,11 +78,6 @@ class instance_halls_of_lightning : public InstanceMapScript
return true;
}
ObjectGuid GetGuidData(uint32 type) const override
{
return InstanceScript::GetGuidData(type);
}
};
InstanceScript* GetInstanceScript(InstanceMap* map) const override