Core/Objects: Eliminate unneccessary temporary objects and double map lookups when building SMSG_UPDATE_OBJECT

(cherry picked from commit 38a209276d)
This commit is contained in:
Shauren
2024-10-28 00:52:19 +01:00
parent df17886636
commit 90db558697

View File

@@ -505,15 +505,7 @@ void Object::ClearUpdateMask(bool remove)
void Object::BuildFieldsUpdate(Player* player, UpdateDataMapType& data_map) const
{
UpdateDataMapType::iterator iter = data_map.find(player);
if (iter == data_map.end())
{
std::pair<UpdateDataMapType::iterator, bool> p = data_map.emplace(player, UpdateData());
ASSERT(p.second);
iter = p.first;
}
UpdateDataMapType::iterator iter = data_map.try_emplace(player).first;
BuildValuesUpdateBlockForPlayer(&iter->second, iter->first);
}