mirror of
https://github.com/TrinityCore/TrinityCore.git
synced 2026-01-15 23:20:36 +01:00
Core/Misc: Remove redundant null pointer checks before delete (#24140)
* Identified by clang-tidy readability-delete-null-pointer
This commit is contained in:
@@ -2400,9 +2400,12 @@ void Guild::DeleteMember(SQLTransaction& trans, ObjectGuid guid, bool isDisbandi
|
||||
// Call script on remove before member is actually removed from guild (and database)
|
||||
sScriptMgr->OnGuildRemoveMember(this, player, isDisbanding, isKicked);
|
||||
|
||||
if (Member* member = GetMember(guid))
|
||||
delete member;
|
||||
m_members.erase(lowguid);
|
||||
auto memberItr = m_members.find(guid);
|
||||
if (memberItr != m_members.end())
|
||||
{
|
||||
delete memberItr->second;
|
||||
m_members.erase(memberItr);
|
||||
}
|
||||
|
||||
// If player not online data in data field will be loaded from guild tabs no need to update it !!
|
||||
if (player)
|
||||
|
||||
@@ -75,7 +75,7 @@ bool FileLoader::prepareLoadedData()
|
||||
|
||||
void FileLoader::free()
|
||||
{
|
||||
if (data) delete[] data;
|
||||
delete[] data;
|
||||
data = 0;
|
||||
data_size = 0;
|
||||
version = 0;
|
||||
|
||||
@@ -122,7 +122,7 @@ void MPQFile::seekRelative(int offset)
|
||||
|
||||
void MPQFile::close()
|
||||
{
|
||||
if (buffer) delete[] buffer;
|
||||
delete[] buffer;
|
||||
buffer = 0;
|
||||
eof = true;
|
||||
}
|
||||
|
||||
@@ -128,7 +128,7 @@ void MPQFile::seekRelative(int offset)
|
||||
|
||||
void MPQFile::close()
|
||||
{
|
||||
if (buffer) delete[] buffer;
|
||||
delete[] buffer;
|
||||
buffer = 0;
|
||||
eof = true;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user