Core/Misc: Fix issues reported by static analysis

Coverity defect IDs: 1022861, 1022862, 1022863, 1302435, 1302439, 1302440

(cherry picked from commit 25881ca95f)

Conflicts:
	src/server/scripts/Outland/HellfireCitadel/ShatteredHalls/shattered_halls.cpp
	src/server/scripts/Outland/zone_hellfire_peninsula.cpp
This commit is contained in:
jackpoz
2015-05-30 23:09:34 +02:00
committed by DDuarte
parent 65dc69c17b
commit 986deaa977

View File

@@ -903,17 +903,15 @@ class boss_yogg_saron : public CreatureScript
DoCast(me, SPELL_KNOCK_AWAY);
me->ResetLootMode();
switch (_instance->GetData(DATA_KEEPERS_COUNT))
{
case 0:
me->AddLootMode(LOOT_MODE_HARD_MODE_4);
case 1:
me->AddLootMode(LOOT_MODE_HARD_MODE_3);
case 2:
me->AddLootMode(LOOT_MODE_HARD_MODE_2);
case 3:
me->AddLootMode(LOOT_MODE_HARD_MODE_1);
}
uint32 keepersCount = _instance->GetData(DATA_KEEPERS_COUNT);
if (keepersCount == 0)
me->AddLootMode(LOOT_MODE_HARD_MODE_4);
if (keepersCount <= 1)
me->AddLootMode(LOOT_MODE_HARD_MODE_3);
if (keepersCount <= 2)
me->AddLootMode(LOOT_MODE_HARD_MODE_2);
if (keepersCount <= 3)
me->AddLootMode(LOOT_MODE_HARD_MODE_1);
}
void SpellHit(Unit* /*caster*/, SpellInfo const* spell) override