mirror of
https://github.com/TrinityCore/TrinityCore.git
synced 2026-01-21 01:37:37 +01:00
Remove crude check in proc system preventing charges drop in proc system for absorbs.
To preserve effect, code must be placed for charge handler to skip procs with 0 damage. This code is preventing procs that should happen (like Savage Defense, or CCs) --HG-- branch : trunk
This commit is contained in:
@@ -13851,15 +13851,6 @@ void Unit::ProcDamageAndSpellFor(bool isVictim, Unit * pTarget, uint32 procFlag,
|
||||
// If not trigger by default and spellProcEvent == NULL - skip
|
||||
if (!isTriggerAura[aurEff->GetAuraType()] && triggerData.spellProcEvent == NULL)
|
||||
continue;
|
||||
uint32 triggered_spell_id = aurEff->GetSpellProto()->EffectTriggerSpell[i];
|
||||
// check for positive auras that proc with charge drop
|
||||
bool positive = (!triggered_spell_id && IsPositiveSpell(aurEff->GetId()) && aurEff->GetBase()->GetCharges()) ||
|
||||
// check for positive auras that triggers unknown spells (Blessing Recovery, etc...)
|
||||
(!sSpellStore.LookupEntry(triggered_spell_id) && IsPositiveSpell(aurEff->GetId())) ||
|
||||
// final check for positive triggered spell
|
||||
IsPositiveSpell(triggered_spell_id);
|
||||
if (!damage && (procExtra & PROC_EX_ABSORB) && isVictim && positive)
|
||||
continue;
|
||||
// Some spells must always trigger
|
||||
if (!triggered || isAlwaysTriggeredAura[aurEff->GetAuraType()])
|
||||
triggerData.effMask |= 1<<i;
|
||||
|
||||
Reference in New Issue
Block a user