Core/Misc: Fix static analysis issues

(cherry picked from commit 7e73f5f1ed)

dep/g3dlite/source/fileutils.cpp

@@ -490,7 +490,7 @@ void parseFilename(
 
         }
 
-    } else if ((f.size() >= 2) & isSlash(f[0]) && isSlash(f[1])) {
+    } else if ((f.size() >= 2) && isSlash(f[0]) && isSlash(f[1])) {
         
         // e.g. //foo
         root = f.substr(0, 2);

src/server/game/Battlegrounds/Zones/BattlegroundAB.cpp

@@ -162,7 +162,7 @@ void BattlegroundAB::PostUpdateImpl(uint32 diff)
 
                 if (team == TEAM_ALLIANCE)
                     UpdateWorldState(BG_AB_OP_RESOURCES_ALLY, m_TeamScores[team]);
-                else if (team == TEAM_HORDE)
+                else
                     UpdateWorldState(BG_AB_OP_RESOURCES_HORDE, m_TeamScores[team]);
                 // update achievement flags
                 // we increased m_TeamScores[team] so we just need to check if it is 500 more than other teams resources

src/server/game/Events/GameEventMgr.h

@@ -59,7 +59,7 @@ typedef std::map<uint32 /*condition id*/, GameEventFinishCondition> GameEventCon
 
 struct GameEventData
 {
-    GameEventData() : start(1), end(0), nextstart(0), occurence(0), length(0), holiday_id(HOLIDAY_NONE), state(GAMEEVENT_NORMAL),
+    GameEventData() : start(1), end(0), nextstart(0), occurence(0), length(0), holiday_id(HOLIDAY_NONE), holidayStage(0), state(GAMEEVENT_NORMAL),
                       announce(0) { }
     time_t start;           // occurs after this time
     time_t end;             // occurs before this time

src/server/scripts/Northrend/zone_dragonblight.cpp

@@ -409,7 +409,7 @@ public:
                 tree->AI()->Talk(SAY_WALKER_FRIENDLY, player);
                 tree->DespawnOrUnsummon(1000);
             }
-            else if (roll == 0) // enemy version
+            else // enemy version
             {
                 tree->AI()->Talk(SAY_WALKER_ENEMY, player);
                 tree->SetFaction(FACTION_MONSTER);

src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/instance_serpent_shrine.cpp

@@ -148,7 +148,7 @@ class instance_serpent_shrine : public InstanceMapScript
                                         player->CastSpell(player, SPELL_SCALDINGWATER, true);
 
                                 }
-                                else if (Water == WATERSTATE_FRENZY)
+                                else
                                 {
                                     //spawn frenzy
                                     if (DoSpawnFrenzy)