Core/Misc: Fixed some uninitialized variables

(cherry picked from commit 17a783ce45)

src/common/Metric/Metric.h

@@ -51,7 +51,7 @@ struct MetricData
 {
     std::string Category;
     SystemTimePoint Timestamp;
-    MetricDataType Type;
+    MetricDataType Type = METRIC_DATA_VALUE;
 
     // LogValue-specific fields
     Optional<std::variant<std::array<MetricTag, 2>, std::vector<MetricTag>>> Tags;

src/server/game/Server/WorldSession.cpp

@@ -20,7 +20,6 @@
 */
 
 #include "WorldSession.h"
-#include "QueryHolder.h"
 #include "AccountMgr.h"
 #include "AuthenticationPackets.h"
 #include "BattlePetMgr.h"
@@ -121,6 +120,7 @@ WorldSession::WorldSession(uint32 id, std::string&& name, uint32 battlenetAccoun
     _os(std::move(os)),
     _clientBuild(build),
     _clientBuildVariant(clientBuildVariant),
+    _realmListSecret(),
     _battlenetRequestToken(0),
     _logoutTime(0),
     m_inQueue(false),

src/server/game/World/World.h

@@ -98,7 +98,7 @@ enum WorldTimers
 };
 
 /// Configuration elements
-enum WorldBoolConfigs
+enum WorldBoolConfigs : uint32
 {
     CONFIG_DURABILITY_LOSS_IN_PVP = 0,
     CONFIG_ADDON_CHANNEL,
@@ -201,7 +201,7 @@ enum WorldBoolConfigs
     BOOL_CONFIG_VALUE_COUNT
 };
 
-enum WorldFloatConfigs
+enum WorldFloatConfigs : uint32
 {
     CONFIG_GROUP_XP_DISTANCE = 0,
     CONFIG_MAX_RECRUIT_A_FRIEND_DISTANCE,
@@ -228,7 +228,7 @@ enum WorldFloatConfigs
     FLOAT_CONFIG_VALUE_COUNT
 };
 
-enum WorldIntConfigs
+enum WorldIntConfigs : uint32
 {
     CONFIG_COMPRESSION = 0,
     CONFIG_INTERVAL_SAVE,
@@ -434,14 +434,14 @@ enum WorldIntConfigs
     INT_CONFIG_VALUE_COUNT
 };
 
-enum WorldInt64Configs
+enum WorldInt64Configs : uint32
 {
     CONFIG_CHARACTER_CREATING_DISABLED_RACEMASK,
     INT64_CONFIT_VALUE_COUNT
 };
 
 /// Server rates
-enum Rates
+enum Rates : uint32
 {
     RATE_HEALTH = 0,
     RATE_POWER_MANA,