Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-15 23:20:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Scripts/Spells: Rewrite druid talent Shooting Stars to have reduced proc chance on multiple targets

Browse Source
This commit is contained in:
Shauren
2025-08-24 14:46:20 +02:00
parent ac15007872
commit b0de792bb8
2 changed files with 46 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
sql/updates/world/master/2025_08_24_00_world.sql Normal file
View File

@@ -0,0 +1,3 @@
DELETE FROM `spell_script_names` WHERE `ScriptName`='spell_dru_shooting_stars';
INSERT INTO `spell_script_names` (`spell_id`,`ScriptName`) VALUES
(202342,'spell_dru_shooting_stars');

52
src/server/scripts/Spells/spell_druid.cpp
View File

@@ -1700,26 +1700,60 @@ class spell_dru_savage_roar_aura : public AuraScript
}
};
// 164815 - Sunfire
// 164812 - Moonfire
// 202342 - Shooting Stars
class spell_dru_shooting_stars : public AuraScript
{
bool Validate(SpellInfo const* /*spellInfo*/) override
{
return ValidateSpellInfo({ SPELL_DRUID_SHOOTING_STARS, SPELL_DRUID_SHOOTING_STARS_DAMAGE });
return ValidateSpellInfo({ SPELL_DRUID_SHOOTING_STARS_DAMAGE })
&& ValidateSpellEffect({ { SPELL_DRUID_MOONFIRE_DAMAGE, EFFECT_1 }, { SPELL_DRUID_SUNFIRE_DAMAGE, EFFECT_1 } })
&& sSpellMgr->AssertSpellInfo(SPELL_DRUID_MOONFIRE_DAMAGE, DIFFICULTY_NONE)->GetEffect(EFFECT_1).IsAura(SPELL_AURA_PERIODIC_DAMAGE)
&& sSpellMgr->AssertSpellInfo(SPELL_DRUID_SUNFIRE_DAMAGE, DIFFICULTY_NONE)->GetEffect(EFFECT_1).IsAura(SPELL_AURA_PERIODIC_DAMAGE);
}
void OnTick(AuraEffect const* /*aurEff*/)
void OnTick(AuraEffect const* aurEff) const
{
if (Unit* caster = GetCaster())
if (AuraEffect const* shootingStars = caster->GetAuraEffect(SPELL_DRUID_SHOOTING_STARS, EFFECT_0))
if (roll_chance_i(shootingStars->GetAmount()))
caster->CastSpell(GetTarget(), SPELL_DRUID_SHOOTING_STARS_DAMAGE, true);
Unit* caster = GetTarget();
std::vector<Unit*> moonfires;
std::vector<Unit*> sunfires;
auto work = [&, druid = caster->GetGUID()](Unit* target)
{
if (target->HasAuraEffect(SPELL_DRUID_MOONFIRE_DAMAGE, EFFECT_1, druid))
moonfires.push_back(target);
if (target->HasAuraEffect(SPELL_DRUID_SUNFIRE_DAMAGE, EFFECT_1, druid))
sunfires.push_back(target);
};
Trinity::UnitWorker worker(caster, work);
Cell::VisitAllObjects(caster, worker, 100.0f);
ProcessDoT(aurEff, caster, moonfires);
ProcessDoT(aurEff, caster, sunfires);
}
static void ProcessDoT(AuraEffect const* aurEff, Unit* caster, std::vector<Unit*>& targets)
{
if (targets.empty())
return;
float chance = float(aurEff->GetAmount()) * std::sqrt(float(targets.size()));
float procs;
if (roll_chance_f(std::modf(chance / 100.0f, &procs) * 100.0f))
procs += 1.0f;
if (procs <= 0.0f)
return;
Trinity::Containers::RandomResize(targets, procs);
for (Unit* target : targets)
caster->CastSpell(target, SPELL_DRUID_SHOOTING_STARS_DAMAGE, CastSpellExtraArgsInit{
.TriggerFlags = TRIGGERED_IGNORE_CAST_IN_PROGRESS | TRIGGERED_DONT_REPORT_CAST_ERROR
});
}
void Register() override
{
OnEffectPeriodic += AuraEffectPeriodicFn(spell_dru_shooting_stars::OnTick, EFFECT_1, SPELL_AURA_PERIODIC_DAMAGE);
OnEffectPeriodic += AuraEffectPeriodicFn(spell_dru_shooting_stars::OnTick, EFFECT_0, SPELL_AURA_PERIODIC_DUMMY);
}
};