Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-16 07:30:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/Misc: Fix static analysis issues

Browse Source 
Fix uninitialized values spotted by coverity.
Remove unused "dynamic analysis" code, use Valgrind or another dynamic analysis tool instead if needed.
This commit is contained in:
jackpoz
2014-05-12 21:18:59 +02:00
parent 0334c21394
commit b17e3246fe
3 changed files with 2 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/server/game/Grids/GridStates.cpp
View File

@@ -20,18 +20,6 @@
#include "GridNotifiers.h"
#include "Log.h"
#ifdef TRINITY_DEBUG
bool GridState::checkMagic()
{
if (i_Magic != MAGIC_TESTVAL)
{
TC_LOG_ERROR("misc", "!!! GridState: Magic value gone !!!");
return false;
}
return true;
}
#endif
void InvalidState::Update(Map&, NGridType&, GridInfo&, uint32) const
{ }

7
src/server/game/Grids/GridStates.h
View File

@@ -27,13 +27,6 @@ class Map;
class GridState
{
public:
#ifdef TRINITY_DEBUG
#define MAGIC_TESTVAL 0xFBE823BA
GridState() { i_Magic = MAGIC_TESTVAL; }
bool checkMagic();
void setMagic() { i_Magic = MAGIC_TESTVAL; }
unsigned int i_Magic;
#endif
virtual ~GridState() { };
virtual void Update(Map &, NGridType&, GridInfo &, uint32 t_diff) const = 0;
};

2
src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/halls_of_reflection.cpp
View File

@@ -347,6 +347,8 @@ class npc_jaina_or_sylvanas_intro_hor : public CreatureScript
npc_jaina_or_sylvanas_intro_horAI(Creature* creature) : ScriptedAI(creature)
{
_instance = me->GetInstanceScript();
_utherGUID = 0;
_lichkingGUID = 0;
}
void sGossipSelect(Player* player, uint32 /*menuId*/, uint32 gossipListId) override